Date:   Mon, 29 Nov 2021 23:31:16 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-mmc@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs
Message-ID: <YaXTRJO9Wbsh8n05@sol.localdomain>
References: <20211130040306.148925-1-ebiggers@kernel.org>
 <20211130040306.148925-4-ebiggers@kernel.org>
 <YaXPIYHg8Xnk1Lbh@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YaXPIYHg8Xnk1Lbh@kroah.com>
Precedence: bulk

On Tue, Nov 30, 2021 at 08:13:37AM +0100, Greg Kroah-Hartman wrote:
> >  Documentation/block/queue-sysfs.rst |  30 +++++
> 
> Same objection as before.  Please add these to Documentation/ABI/

As I said before, this is where all the blk-sysfs stuff is documented currently.
If you consider this a hard requirement, then I'll get started on a patch that
moves all of queue-sysfs.rst into Documentation/ABI/, as it's silly to change it
for just this one and not the 23 other blk-sysfs attributes with exactly the
same issue.

> otherwise when running 'scripts/get_abi undefined' will show these new
> sysfs files you are adding as having no documentation :(

Perhaps this should be part of checkpatch?

- Eric