Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B9EC433EF for ; Tue, 30 Nov 2021 08:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239739AbhK3Iqi (ORCPT ); Tue, 30 Nov 2021 03:46:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239665AbhK3Iqd (ORCPT ); Tue, 30 Nov 2021 03:46:33 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D70DC061574 for ; Tue, 30 Nov 2021 00:43:13 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id j6-20020a17090a588600b001a78a5ce46aso17765326pji.0 for ; Tue, 30 Nov 2021 00:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fHVy98BTaUQF52BWKLZtuQVRzz01N8+H95C8cB4Mhtg=; b=dkAqbyqTPRY4L/DB0uLdYdRPU6b1N+TybDCY0FHBvSZn/2S8Ae0v0tdFZwYj7zBLDi 8QqrjFuNnxaIPD8BAr2rJhpwB2cDkqWynWjh0Ac4qLo6dTsE54UqsPiCOX+RddtIHAO2 8JBLdxXwcjC/F/oqOtekIMDpqcxK4ymeEg2t/OKu6eb2DQDHJUzH+N2n7plAhq184vX+ 3ilr42mjOAMqMwT+OGrhYyComtrMz2+AeX0KPKFk06V5xiL+cTmcyS3TObk+6xDdalRD 5Gaot3pJL+djNMmQ9F1IXX3Sxk97PgB1c7iou+/rl9Rq5op0ena4PcLEXQYlr5biumJp qtzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fHVy98BTaUQF52BWKLZtuQVRzz01N8+H95C8cB4Mhtg=; b=dolro4h12kH9s2PltOOc7NgzcFE1vCxSlQbz9wHiRT+jwApkC0FIzAepAg3wbt0Z6F ZY6ISMT+NIPNL3HNp1X/K0CIEmYdRRxgAUmUc6YbgJq8B81It+heb3NAPzqjBNLSlspy VNxPzSPYp6MdBCstMjxMDN6vMhdur+yW7XxvzHV6282U3lNsc5GbmVYPmbCMSy16MdXI r8eTeoQFfgtM6pLBTMqeDrYm/UU7D2MbiFuho9+uMvYkMO5sQLnzYzq4yVeW+RN8LWvr jwniIWA0ptzC4nAMQJjQwYzGzznhOv2b4/aojJdER12GTCn/OQOBuM98uQy8Kb/YNUuo Dvng== X-Gm-Message-State: AOAM5333GzkSKoSuSi2LGI6Z/c78pd98M2DoX7Y8wOE/ydbSdwPtvscu OrOkh+hqtb3P/0QUKJw8n37j5g== X-Google-Smtp-Source: ABdhPJxue2FBF6O8NbPbziRrwGNOciaOEZ/z8FnZ1b/zhjeFgaTTmvLKkjb9rz4cIuDD9UU5GWKBaQ== X-Received: by 2002:a17:903:24d:b0:143:beb5:b6b1 with SMTP id j13-20020a170903024d00b00143beb5b6b1mr66622707plh.54.1638261792852; Tue, 30 Nov 2021 00:43:12 -0800 (PST) Received: from google.com ([2401:fa00:1:10:6cb4:a0cc:6d7f:cba7]) by smtp.gmail.com with ESMTPSA id v10sm20770644pfu.123.2021.11.30.00.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 00:43:12 -0800 (PST) Date: Tue, 30 Nov 2021 16:43:07 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v8 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211129101946.6008-1-allen-kh.cheng@mediatek.com> <20211129101946.6008-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211129101946.6008-4-allen-kh.cheng@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 29, 2021 at 06:19:45PM +0800, allen-kh.cheng wrote: > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static int mtk_adsp_mbox_probe(struct platform_device *pdev) > +{ [...] > + mbox->dev = dev; > + mbox->ops = &mtk_adsp_mbox_chan_ops; > + mbox->txdone_irq = false; > + mbox->txdone_poll = true; > + mbox->of_xlate = mtk_adsp_mbox_xlate; > + mbox->num_chans = 1; > + mbox->chans = devm_kzalloc(mbox->dev, sizeof(*mbox->chans), GFP_KERNEL); I have commented in the v3[1]. To be neat, I prefer to use "dev" instead of "mbox->dev". If you ever have the chance to respin the series, please fix it. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20211124084514.28002-3-allen-kh.cheng@mediatek.com/#24614933