Date:   Tue, 30 Nov 2021 10:49:41 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     kbuild@lists.01.org, lianzhi chang <changlianzhi@uniontech.com>,
        linux-kernel@vger.kernel.org, lkp@intel.com,
        kbuild-all@lists.01.org, dmitry.torokhov@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org, 282827961@qq.com
Subject: Re: [PATCH v18] tty: Fix the keyboard led light display problem
Message-ID: <YaXlpQdOHT2LEpPR@smile.fi.intel.com>
References: <20211129040445.24134-1-changlianzhi@uniontech.com>
 <202111291912.gGbp6mtv-lkp@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202111291912.gGbp6mtv-lkp@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Nov 30, 2021 at 10:53:37AM +0300, Dan Carpenter wrote:
> Hi lianzhi,
> 
> url:    https://github.com/0day-ci/linux/commits/lianzhi-chang/tty-Fix-the-keyboard-led-light-display-problem/20211129-120853
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: i386-randconfig-m021-20211128 (https://download.01.org/0day-ci/archive/20211129/202111291912.gGbp6mtv-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> New smatch warnings:
> drivers/tty/vt/keyboard.c:425 vt_set_leds_compute_shiftstate() warn: was && intended here instead of ||?

Indeed, how this had been tested?

> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang  2021-11-29 @425  	if (kb->kbdmode != VC_RAW ||
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang  2021-11-29  426  		 kb->kbdmode != VC_MEDIUMRAW ||
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang  2021-11-29  427  		 kb->kbdmode != VC_OFF) {
> 
> && was intended instead of ||.
> 
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang  2021-11-29  428  		vt_switch = true;
> 63f24a7fafd448 drivers/tty/vt/keyboard.c Jiri Slaby     2021-01-05  429  		set_leds();
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang  2021-11-29  430  	}

-- 
With Best Regards,
Andy Shevchenko