Subject: Re: [PATCH] mtd: dataflash: Add device-tree SPI IDs
To:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>
Cc:     linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, Mark Brown <broonie@kernel.org>
References: <20211119183316.1329089-1-miquel.raynal@bootlin.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <a799095a-e046-ae56-c2db-f527e199b5fb@nvidia.com>
Date:   Tue, 30 Nov 2021 08:53:08 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211119183316.1329089-1-miquel.raynal@bootlin.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHozNnhPV2F3NlV5bXNjdEhCUXh5OC8rRGttUTB4bGpiQ01saXZxaFRLU09W?=
 =?utf-8?B?S0R5dHFBSnJuNkxBYm1pOElMbzJYTUtQTzBia1NiYmVMY201d1I2S2xBZDds?=
 =?utf-8?B?dEdHdzgwT3dRaHVzV01NWWdlOXJiTEF0M3hBVWc3RHRuMkdqUVRreklOT2FR?=
 =?utf-8?B?Uy9PSFBqQVhTY1NMYmMwT2d1akYyeC9sSm9ocitRVS9DVy9oSjg1c1BPYzZs?=
 =?utf-8?B?Yzl4bU9oMWtpUEdrd2hZY3VrTG96WXBQd3h1cGVGeXFjWHpxVE1aWGx4N1lB?=
 =?utf-8?B?Yzd6clhrbkJscUptY2dHSW1NRkE4c21NYXpJZUJTZWh6S1NKVEZIRitvSUFT?=
 =?utf-8?B?NUVsOUl6N2NUQThldXBhdWhGV0Y0UlNwOVRlUUdpdE11enk2TXFkNEV6aG5p?=
 =?utf-8?B?b1VRbElXQ1FFVFF0RzVmMXJYL0RnTmZUVC9tRVdyN3VUeGdDakp6bGpUaW1P?=
 =?utf-8?B?ZG9ibDZNd1RIb3dzRGd6djBlR0FzUDlkT085K2JveTd3U05PQzZrKzBJbmgz?=
 =?utf-8?B?NmRpSU45ZGpZUHdYYjA1cTdrVk1ZVy9pMlZ0NEVGNllidXZNS3l0UkhiNWlB?=
 =?utf-8?B?RHduYmYzVDlxR2hzMHJKU1pZa2pxY0JyWkIzZnBTWmhmQ05sa0Jkc1JqSXZ6?=
 =?utf-8?B?aS94YldjTnNCU1RaZjJQNjBOSjZJd2Nnd2x4ajlmSmNaMTdWSzk4YkZkVUdr?=
 =?utf-8?B?MmNxcDZKc25GK2dNUTcreWIxc1pxcHVCRTFuZVVZWTY4ZXI0N3RNZjUxTjVM?=
 =?utf-8?B?ZnNlbDk3ZjRQTjloeDZDRzdqN1lqN1Y5eFFGTllJZEpQY1hxN3NaZDBPSjhV?=
 =?utf-8?B?NElVWFloRGtmbWdERjNvNy9lam9CRGxPc2FuZGg4bDNxRFlUcnMrRjVWcmQ3?=
 =?utf-8?B?VE8yTnQ3djVZTVQ2bExVZ1lyWkRXU2NLZ2xWVW5zd3QzaWV4WWtZWXozMXhU?=
 =?utf-8?B?RzB0Q3dTdVFqTjNDdGtBcnZpZnBQTmZrS2hkL0FCbkFLUjg1ZElicVY5bFl6?=
 =?utf-8?B?RExUWmtlVTd5R295ZlFFTGFGdXhsRmdTWExLYXBxMHhuR29Ua2g4SkVsSHBu?=
 =?utf-8?B?ckNlYkVYdFcyUGVKdUpWQmkrWDlYMzVVMEpOVUFUalBQbkZLMzRxMzZKUXV6?=
 =?utf-8?B?SU5uM2JDdS9ueUNFd0xra3VDa2JhMVI5R2QyKzZiNFhrRGhpUXVPTEdveVhm?=
 =?utf-8?B?dUIvVWZpeW82QzltRzZxcHpnVVUzVEFBM1lKdFJ2WnQvZ2poOEFMZUk4K1p6?=
 =?utf-8?B?QzhmNkpNdlFkMWo0clZqUFd2V0Vjd2JHYWJIUkFFR2s2RGVqOXFXNi8yUGEw?=
 =?utf-8?B?OUhNNDI5dngvTmI5SWx4YzdTYjUyd1BYbWZmOTFvSUc0TkNlUldqemRsay82?=
 =?utf-8?B?MitLZjdZM1VZNHVTNFg2RDUrWWVFeFhEN2lyVHh1U0M4ZS9hN3ZueHBtaGhI?=
 =?utf-8?B?Wm5YdkpLN0ZPVG1JV2ZiTEdCc3pBTjBvSkVqSHhpbm0xQ1hGOEhOVzFEdSt6?=
 =?utf-8?B?MDUxdFpwcGJqcHBNNUtCYlpZaVhsaUdBNGEyMUxNQUhYNWJQK1g2dkpSVmto?=
 =?utf-8?B?bHhoMG1Ublh4Wk05aVRVajY1ZzJxLzM5cmpKL2dTODU4Nml6dEpJTHZPQktn?=
 =?utf-8?B?YTVvV0RKc2V6dDJ6c0gwbVRYOSt6aTNjV0JqV1ZXTU54TUNHVnJFVS9ZZUdF?=
 =?utf-8?B?MGxNQUpNNGxrMWZyNnUzNmRJaUl5NjVYL29QQU9tNzhIZUpEamdnVkhBZlB5?=
 =?utf-8?Q?g9po3rSIh2DDjud2D1nJey9Jy980+CKlVNFGmjx?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1088cd04-486f-48ca-9df6-08d9b3ded8a7
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 08:53:15.0144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8m9Dsn3rjbc6Q+DUEiVcPvAxa01LKDGjmMP7ZNjdDhAqmJCDRaQ8BP+ipl654A/wVYMH+9iyo4HtE8y/rAaBEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5582
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Miquel,

On 19/11/2021 18:33, Miquel Raynal wrote:
> On Mon, 2021-11-15 at 11:36:55 UTC, Jon Hunter wrote:
>> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
>> compatible") added a test to check that every SPI driver has a
>> spi_device_id for each DT compatiable string defined by the driver
>> and warns if the spi_device_id is missing. The spi_device_ids are
>> missing for the dataflash driver and the following warnings are now
>> seen.
>>
>>   WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45
>>   WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,dataflash
>>
>> Fix this by adding the necessary spi_device_ids.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> 
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.


Please can you submit as a fix for v5.16? The commit that introduced 
this is already in the mainline.

Thanks
Jon

-- 
nvpublic