From:   Billy Tsai <billy_tsai@aspeedtech.com>
To:     =?utf-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= 
        <u.kleine-koenig@pengutronix.de>
CC:     "b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [PATCH] hwmon: (pwm-fan) Let ctx->pwm_value be assigned only in
 __set_pwm
Thread-Topic: [PATCH] hwmon: (pwm-fan) Let ctx->pwm_value be assigned only in
 __set_pwm
Thread-Index: AQHX5ZZIiry9UUnfAUqsCJRIYxGT8qwbo1UAgACsU4A=
Date:   Tue, 30 Nov 2021 09:12:15 +0000
Message-ID: <706A57A6-C34C-425B-B432-2CDF18A344B1@aspeedtech.com>
References: <20211130030046.3920-1-billy_tsai@aspeedtech.com>
 <20211130065526.jqm7ix62y6om7ovw@pengutronix.de>
In-Reply-To: <20211130065526.jqm7ix62y6om7ovw@pengutronix.de>
Accept-Language: zh-TW, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Ylc1S08wMU4wQ29nVGpyMnJ6S1NDdU8waHRFRXU2bW03TzV5TmRmd1A0QnNP?=
 =?utf-8?B?U2h5N2FiUjliZ3VtcHhLa202SGVTc2NEWFl2ZHBxZmpXa1RXbHM4dXU4Wm10?=
 =?utf-8?B?T1JwY1lqSkZ2MWdpanljbWxQNmtuVHExNEtsOE0yUmtjSWtJTCtmV1JNWGps?=
 =?utf-8?B?QjYycVdDSEZtNDlqbEM2a1RVaGh4VHBkVUI3aFI3MWJodVZZbHA3ZEdJRFVu?=
 =?utf-8?B?U21kWm1CK3QrT3o3WC95MnR0M1ZKcjZucUU3VTJNTEFoQ0JzbkpWcG05RDRD?=
 =?utf-8?B?ZzVJYWlTd0dZa1p4QWt2VEFaM1d6MEVldmp0QXQ3MnZidTFVclkxbW5sMVZk?=
 =?utf-8?B?RExsVlBoa1NaSFZNWXc2bnkybmF3eTZnVkdrY3Z2MFdPWTc5eFFGay91c2sw?=
 =?utf-8?B?Ti9qMGRsL1RwR1NNUmpzam5WdExNVnNGZk9WVGpnQ3UrcEFRcU14RTZIVVhy?=
 =?utf-8?B?NnlTQjVjSmVOS1BrblZJdFVwcG54Y2VSL2k1Sk9hMTBKaFdrQ0hzM2llS0hx?=
 =?utf-8?B?Q0hsSVRqT3cvSTk5MUF2WDltSkwwcVRXSi81YjFTY1hmdGdvQnBwUWNCOWlW?=
 =?utf-8?B?alpFSGlXc1UrVzk3eU1UWGh0cDlIR1hpZElta2tUUWJaV1hJdTM4WUVzWU1R?=
 =?utf-8?B?T0pHMVV6RXVGQkxNdmJDZzdVSU1xY2YwZnNLaEZ5R252emdGbmtQbE1rWHRm?=
 =?utf-8?B?ZVN2Qk5MMU9VMHRZaGI0NXkvMk96V2dTc3BXbkZ1am82aU9DSVNDakxpRmNo?=
 =?utf-8?B?SWxBUDh6NnIxVUlqQ1NnYjIzSGRGWUJoY1JzOHV5aVpHd2NFdFlTVU85Zm15?=
 =?utf-8?B?TzJWTTE0c2RwMzZrWGNjRW9pSXhNUExOeXlqcnNZOEg0aUliejZrRnhVcGx4?=
 =?utf-8?B?eW95TmIrMkRYaDZML2lnV1BTQUNHTXJWdFJESDRRZ21USTIvbjAvNGRtQ0Uv?=
 =?utf-8?B?dTMxNklDMHB3OXI3SzArM3l4aEkrbGQ3eFhIUlNXZkV0Qk5Cc25kSjY5K0p1?=
 =?utf-8?B?bzFLTkFDYlZKSjhUWUtCV3pDeTQ2U3ZNQllteXpCMEtjM094M1M3WlZLK0RP?=
 =?utf-8?B?NXdwQm51eDk4Sm1xRVAyaEtEQVZYY3Z1OHdJeWhmazFManBSdkswdm83WUIy?=
 =?utf-8?B?YmxYYmE0K1lwMEZaQVhBaU9nWFB1TkdJNlgwQ1lHV3NCbFcza2REVERFazdT?=
 =?utf-8?B?RkQrR2xKOWZKUVNPeUlZZ1dJUThkcFdlREJCOWswOHlVN2RwV0tXU2RJVUJh?=
 =?utf-8?B?T3VISWFzaUx2MVR5Y0Z0N3ZlMmE1QUlPQkt5dkFTUWFNQnlIakNmdXREU3pk?=
 =?utf-8?B?NzBwYWd5TXRkK1NtbDlLQ0ZJYmJvd1BPTmI5QUYxTTdIandlVGhoLy93T3VO?=
 =?utf-8?B?NjNIZWZQeDBXN25sakVhbzYrd3YwVFJIMHJDdHBuM2tXSGpkdFgrMHlhM3pX?=
 =?utf-8?B?L3BVdmM1d1JRUXFDbGtHUy9xOTdBZC9MTmlXaUprRDAybFdHTmx1S045V0FY?=
 =?utf-8?B?OFZkNUhRQWhndEgzdFQzb2R4UFh4UTkzM0F1ZmZkN1lWOG1jdy85Z0VDZ3Zt?=
 =?utf-8?B?NUJ6MzVMeGJXNWxlUmNyd0hKbkpzcE9ydG0rdVdxMVNOZjMyM0REQnAxa2Js?=
 =?utf-8?B?OCt3Zzh6ZzJ0ektLRU5iRnVpb0FOQm0rUmlpc0VBK1o5RVFpeXpmdllxNlo2?=
 =?utf-8?B?MTFrOHZXcm9TM1YwakMvQzEyTVF6NXVGbzkrSDhyczZGZTViZTVYYkYzKzVZ?=
 =?utf-8?B?NFFNV29IT1d4ajhKbjZmT3hsanJCR1VJRUZKWjZURGtMei9VWXJQY0R0SkZP?=
 =?utf-8?B?M2dMWFRUUkVGbi9hZHNKUDU5MW1EYjBYTWg1ZDVrSEl2akdsaEZlUm5ERU5U?=
 =?utf-8?B?V1oxcitiVjJwSjVIKzZyOFRwRjUwLzA0VGdOckkwNnRzL3JtalNnZlVUeU1z?=
 =?utf-8?B?Zk5aR1dXeVB0MC9tWkc1c0dxODluMkN0U2FFTlowRG9NcjRLV1NrWlV4RmR4?=
 =?utf-8?B?UmtiR0RFOHphRW41T0tPMVFhZW9wcEx5ZWpONThycXcrU3pUdjJ5TG5UTVlS?=
 =?utf-8?B?OWZURTQrc0FyVllLSXh6RXpad0VUc3RGZlFwa29zT2VHelZxcTVNNGhxSzlB?=
 =?utf-8?B?THlkSURPM1l1N0JOZkFCY2ovd1A4bWJRMHk1azlSTkxXSEE0UkgrdXBFb3FY?=
 =?utf-8?B?OUxMWU1oNmY2K2R1WHZvLzI2L29qQXlma2tya3A2Z1N2b3NVcTJheU9xTHF2?=
 =?utf-8?Q?3xdZEYD8EBpNnJzfrmyjIZiDFqGCh+r6xU48z4Eiek=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CC07E5FB57104D47A4EA84B6BB05F905@apcprd06.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3362.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09094648-e4ea-42d5-81aa-08d9b3e180ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2021 09:12:15.6573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Xfzkxnv7DwT98vg+9AHI2LqGfspLwpdg56vpEgC9QBEm4csvBd2UvpvAVS7Ioz9uWbuBH2+69sGSCSfNMtZdjFdyHjRFrnWgMFEJ0LjUPqc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB3330
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

SGkgVXdlLA0KDQpPbiAyMDIxLzExLzMwLCA0OjIxIFBNLCAiVXdlIEtsZWluZS1Lw7ZuaWciIDx1
LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOg0KDQogICAgSGVsbG8sDQoNCiAg
ICBPbiBUdWUsIE5vdiAzMCwgMjAyMSBhdCAxMTowMDo0NkFNICswODAwLCBCaWxseSBUc2FpIHdy
b3RlOg0KICAgID4gICA+IFRoaXMgcGF0Y2ggaXMgdXNlZCB0byBmaXggdGhlIGJ1ZyB3aGVuIHB3
bV9mYW5fcHJvYmUgdGhlIHB3bV92YWx1ZSB3aWxsDQogICAgPiAgID4gYmUgb3V0IG9mIHN5bmMg
d2l0aCB0aGUgUFdNIGhhcmR3YXJlIGRyaXZlcnMuDQogICAgPiAgID4gDQogICAgPiAgID4gRml4
ZXM6IDg2NTg1YzYxOTcyZiAoImh3bW9uOiAocHdtLWZhbikgc3RvcCB1c2luZyBsZWdhY3kgUFdN
IGZ1bmN0aW9ucyBhbmQgc29tZSBjbGVhbnVwcyIpDQogICAgPiAgID4gU2lnbmVkLW9mZi1ieTog
QmlsbHkgVHNhaSA8YmlsbHlfdHNhaUBhc3BlZWR0ZWNoLmNvbT4NCiAgICA+ICAgPiAtLS0NCiAg
ICA+ICAgPiAgZHJpdmVycy9od21vbi9wd20tZmFuLmMgfCAyIC0tDQogICAgPiAgID4gIDEgZmls
ZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQ0KICAgID4gICA+IA0KICAgID4gICA+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL2h3bW9uL3B3bS1mYW4uYyBiL2RyaXZlcnMvaHdtb24vcHdtLWZhbi5jDQog
ICAgPiAgID4gaW5kZXggMTc1MThiNGNhYjFiLi5mMTJiOWEyOGEyMzIgMTAwNjQ0DQogICAgPiAg
ID4gLS0tIGEvZHJpdmVycy9od21vbi9wd20tZmFuLmMNCiAgICA+ICAgPiArKysgYi9kcml2ZXJz
L2h3bW9uL3B3bS1mYW4uYw0KICAgID4gICA+IEBAIC0zMzYsOCArMzM2LDYgQEAgc3RhdGljIGlu
dCBwd21fZmFuX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQogICAgPiAgID4g
IAkJCXJldHVybiByZXQ7DQogICAgPiAgID4gIAl9DQogICAgPiAgID4gIA0KICAgID4gICA+IC0J
Y3R4LT5wd21fdmFsdWUgPSBNQVhfUFdNOw0KICAgID4gICA+IC0NCiAgICA+ICAgPiAgCXB3bV9p
bml0X3N0YXRlKGN0eC0+cHdtLCAmY3R4LT5wd21fc3RhdGUpOw0KDQogICAgPiAgIEFoLCBJIHNl
ZS4gVGhlIGVmZmVjdCBpcyB0aGF0IHRoZSBGQU4gaXMgc3VwcG9zZWQgdG8gYmUgcnVubmluZyBh
dCBmdWxsDQogICAgPiAgIHNwZWVkIGFmdGVyIHByb2JlLCBidXQgdGhpcyBpc24ndCBhc3NlcnRl
ZC4NCg0KICAgID4gICBTbyB0aGUgcGF0Y2ggaXMgZmluZSwgYnV0IEkgc3VnZ2VzdCB0byBtYWtl
IHRoZSBjb21taXQgbG9nIGEgYml0IG1vcmUNCiAgICA+ICAgZnJpZ2h0ZW5pbmcuIFNvbWV0aGlu
ZyBsaWtlOg0KDQogICAgPiAgIAlod21vbjogKHB3bS1mYW4pIEVuc3VyZSB0aGUgZmFuIGdvaW5n
IG9uIGluIC5wcm9iZSgpDQoNCiAgICA+ICAgCUJlZm9yZSBjb21taXQgODY1ODVjNjE5NzJmICgi
aHdtb246IChwd20tZmFuKSBzdG9wIHVzaW5nIGxlZ2FjeQ0KICAgID4gICAJUFdNIGZ1bmN0aW9u
cyBhbmQgc29tZSBjbGVhbnVwcyIpIHB3bV9hcHBseV9zdGF0ZSgpIHdhcyBjYWxsZWQNCiAgICA+
ICAgCXVuY29uZGl0aW9uYWxseSBpbiBwd21fZmFuX3Byb2JlKCkuIEluIHRoaXMgY29tbWl0IHRo
aXMgZGlyZWN0DQogICAgPiAgIAljYWxsIHdhcyByZXBsYWNlZCBieSBhIGNhbGwgdG8gX19zZXRf
cHdtKGN0LCBNQVhfUFdNKSB3aGljaA0KICAgID4gICAJaG93ZXZlciBpcyBhIG5vb3AgaWYgY3R4
LT5wd21fdmFsdWUgYWxyZWFkeSBtYXRjaGVzIHRoZSB2YWx1ZSB0bw0KICAgID4gICAJc2V0Lg0K
DQogICAgPiAgIAlBZnRlciBwcm9iZSB0aGUgZmFuIGlzIHN1cHBvc2VkIHRvIHJ1biBhdCBmdWxs
IHNwZWVkLCBhbmQgdGhlDQogICAgPiAgIAlpbnRlcm5hbCBkcml2ZXIgc3RhdGUgc3VnZ2VzdHMg
aXQgZG9lcywgYnV0IHRoaXMgaXNuJ3QgYXNzZXJ0ZWQNCiAgICA+ICAgCWFuZCBkZXBlbmRpbmcg
b24gYm9vdGxvYWRlciBhbmQgcHdtIGxvdy1sZXZlbCBkcml2ZXIsIHRoZSBmYW4NCiAgICA+ICAg
CW1pZ2h0IGp1c3QgYmUgb2ZmLg0KDQogICAgPiAgIAlTbyBkcm9wIHNldHRpbmcgcHdtX3ZhbHVl
IHRvIE1BWFhfUFdNIHRvIGVuc3VyZSB0aGUgY2hlY2sgaW4NCiAgICA+ICAgCV9fc2V0X3B3bSBk
b2Vzbid0IG1ha2UgaXQgZXhpdCBlYXJseSBhbmQgdGhlIGZhbiBnb2VzIG9uIGFzDQogICAgPiAg
IAlpbnRlbmRlZC4NCg0KICAgID4gICAJQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCiAgICA+
ICAgCUZpeGVzOiA4NjU4NWM2MTk3MmYgKCJod21vbjogKHB3bS1mYW4pIHN0b3AgdXNpbmcgbGVn
YWN5IFBXTSBmdW5jdGlvbnMgYW5kIHNvbWUgY2xlYW51cHMiKQ0KT2ssIEkgd2lsbCB1c2UgdGhp
cyBjb21taXQgbG9nIGFuZCByZXNlbmQgdGhlIHBhdGNoLg0KDQpCZXN0IFJlZ2FyZHMsDQpCaWxs
eSBUc2FpDQoNCg==