Date:   Tue, 30 Nov 2021 13:40:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mark Fasheh <mark@fasheh.com>,
        Wengang Wang <wen.gang.wang@oracle.com>
Cc:     Joel Becker <jlbec@evilplan.org>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Sunil Mushran <sunil.mushran@oracle.com>,
        ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] ocfs2: fix uninitialized variable in ocfs2_dio_wr_get_block()
Message-ID: <20211130104043.GB5827@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?73Rri0gtGoA9oZ1K47iFpQLY/08ajHOlfUYeuHc2SK2agCIA7nHHcPj8o7Bh?=
 =?us-ascii?Q?PiLZ17p+FZPBUb22Q0zLwhFTGdmVfNCXCBxSJVfFRzA1STjrrGrOpsjcnIH+?=
 =?us-ascii?Q?nmJcI+29kbArY2RnZFTH4mG6lAeAYm/2NOPPXt7JB3lGRngL712gxggibJl6?=
 =?us-ascii?Q?BoqAsxbi+PK82fU4T6tVg2Dy06Y5fujM/0BksfulOOio2lgl20EufoVf3DvA?=
 =?us-ascii?Q?5eb4A1kMoTD8GhKBS/mPRrgzMo7+k87t0cyL8gu3jUki0SZCURcaAWrrdlQm?=
 =?us-ascii?Q?2iJym3FTpiBbTNChpZXpl3pF6m6JKBjNvn84haN8RnWZ/jBjISzlxC+Pjx/1?=
 =?us-ascii?Q?5fnpphbzLAZgjELA/oC15aMiFTu+el7UaMOdZkaxDgmr31epxCpQFoR5nLrG?=
 =?us-ascii?Q?OY7qE+5qoRYAK739MwbrAe8yEONR50fgLboUCXIhmWvgP3Fs31QsFW+FDyE5?=
 =?us-ascii?Q?bN7Fwsrljo5tD0kv5AwJSOLclJPvIjITPfnXmvv7qkyoqEVjhjSDaWRYNsOX?=
 =?us-ascii?Q?TEWPbJcF2Umhr9Qbl7HHW+NM2YkKlEl5Jm4QRiyTzeqLJKTnRZksCJ8QT65R?=
 =?us-ascii?Q?ADGuMv1KtezlN29rT9DK3iGB2R65Bn8db3kLwu42k1iesOfLbWzQQhX15JPP?=
 =?us-ascii?Q?CxHXhl64cRHzZZoVrwGJWV60h/+ijSqX0scg1BNhq24uvWPaVUXJU7O42l/0?=
 =?us-ascii?Q?wvjeeKJSf375C9EwU3lmFL+AG6zigSwtd74YjeiqBStwPTD+wUSYAwnBhhd3?=
 =?us-ascii?Q?0kj3fMMU0QA/N2V40eciBP9S6RVEAjX/zRnJ+WQx5gn8VZ7GFa5ao/1YQAQM?=
 =?us-ascii?Q?/CO3TnHmKLgCiIvaCGv+H3R81HAjTbPilw1e0MP1UGuSCClgm0hf7ZwUMwl0?=
 =?us-ascii?Q?jiLRJWtFK3MqMPcGp4Ly+0bvDRXzu7jNK7Aplgos7CT35YYfKfNzWklr/s47?=
 =?us-ascii?Q?7Mb3qKoLyDNkkjSHg7/sJxF0zeQ3iqsGuZRob4mh7ssELVx9ZUzbfDOM5v+I?=
 =?us-ascii?Q?3CDR51lmDXbeUcrHLTVHSk6wwt9VdepRmcCxs8UXnWgUwCMFZVS6JR34Ndd5?=
 =?us-ascii?Q?WPmirushBUTyJIjmFdQ3myvJIQw6+BFR1vdeSLPLy2RY4FP8G3r+8FVxoTvL?=
 =?us-ascii?Q?ZkdBaF9xO1LcQ3VTevSRtr1zqcDk/rvVUt4WX3i1Mo5tFve9wWhUbg5X4gHV?=
 =?us-ascii?Q?M7LnOqJItRUDH/WK1sJCODDN1OyywRrdV0DdudUsZk+amibUU/DI3yMWvnKY?=
 =?us-ascii?Q?iTi6RPlB6r/2vRVXXicpHogQJpJQ607nDfQEoxnqibSpFj+jmHZzWBCGKyzZ?=
 =?us-ascii?Q?Whn+Zgw6j9xH8eOGrQ9LZkh3maExIRHqMo1rjdgnqxTuk+Prw8YoKVX7VRvv?=
 =?us-ascii?Q?HMzLPGgRoRhYJPGDOeWhh6zU8U25wdH8Yg1HW1uQSCQ/w/T4G8FEhGA/AkdI?=
 =?us-ascii?Q?Qe7uk+XK8EYBPY+XaeqQKELO6dH3hV2ucFwnl0X0/Ps8AH3seHTgb6PTW/dU?=
 =?us-ascii?Q?PjxVLMqFH3092kJkGn7bK4l9ibiv2+sKKwByAdnsEnsSJm7pNQQ7KgYXiZKH?=
 =?us-ascii?Q?zEhXyM5iNh1kNPLYal0EGX22bLG1vvodatWFned8K1yTWh58NGw3jqF4aZlx?=
 =?us-ascii?Q?zKUEY1MHcjeSUqUUDi4A7monYvnX4ncgv9xDrukcs9tFBEzXztW8XDO3fXNH?=
 =?us-ascii?Q?F5uMsOAIfEMdZAg+15624NRfavM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3869521e-f45b-414b-4600-08d9b3ede576
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 10:40:58.9369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C0lfTSrpJGzdlXASqd/vSvCzyeIShhfo2xDXoYcnn5fEOINoKclg9hxW0gqBfEpnELEEtGmvboX1CjSXTfmHMPuBINV6U5diTII3QnPg48s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1357
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111300060
X-Proofpoint-GUID: 4WxwEBm_42exwgwYp-y8TcPWVactkJFj
X-Proofpoint-ORIG-GUID: 4WxwEBm_42exwgwYp-y8TcPWVactkJFj
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The callers assume that "*fsdata" is set on the success path, but
that's not necessarily true on this path.

Fixes: 5cffff9e2986 ("ocfs2: Fix ocfs2_page_mkwrite()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Please review this one EXTRA CAREFULLY.  It's from static analysis and
the truth is I'm not 100% sure it's correct.  I'm also not sure that
it's a complete fix.

Especially, please review how this is called from ocfs2_write_begin()
to make sure that this doesn't break anything.


 fs/ocfs2/aops.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 68d11c295dd3..a74a370f16f0 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -1813,6 +1813,7 @@ int ocfs2_write_begin_nolock(struct address_space *mapping,
 	if (ret == -EAGAIN) {
 		BUG_ON(wc->w_target_page);
 		ret = 0;
+		*fsdata = wc;
 		goto out_quota;
 	}
 
-- 
2.20.1