Date:   Tue, 30 Nov 2021 12:11:10 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] mtd: dataflash: Add device-tree SPI IDs
Message-ID: <20211130121110.6026f788@xps13>
In-Reply-To: <a799095a-e046-ae56-c2db-f527e199b5fb@nvidia.com>
References: <20211119183316.1329089-1-miquel.raynal@bootlin.com>
        <a799095a-e046-ae56-c2db-f527e199b5fb@nvidia.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Jon,

jonathanh@nvidia.com wrote on Tue, 30 Nov 2021 08:53:08 +0000:

> Hi Miquel,
> 
> On 19/11/2021 18:33, Miquel Raynal wrote:
> > On Mon, 2021-11-15 at 11:36:55 UTC, Jon Hunter wrote:  
> >> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
> >> compatible") added a test to check that every SPI driver has a
> >> spi_device_id for each DT compatiable string defined by the driver
> >> and warns if the spi_device_id is missing. The spi_device_ids are
> >> missing for the dataflash driver and the following warnings are now
> >> seen.
> >>
> >>   WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45
> >>   WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,dataflash
> >>
> >> Fix this by adding the necessary spi_device_ids.
> >>
> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>  
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.  
> 
> 
> Please can you submit as a fix for v5.16? The commit that introduced this is already in the mainline.

Yes of course. Can you resubmit with a Fixes tag?

> 
> Thanks
> Jon
> 


Thanks,
Miquèl