Subject: Re: [PATCH] mtd: dataflash: Add device-tree SPI IDs
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, Mark Brown <broonie@kernel.org>
References: <20211119183316.1329089-1-miquel.raynal@bootlin.com>
 <a799095a-e046-ae56-c2db-f527e199b5fb@nvidia.com>
 <20211130121110.6026f788@xps13>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <71994534-1c56-f5b4-c054-f643c409d131@nvidia.com>
Date:   Tue, 30 Nov 2021 11:26:02 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211130121110.6026f788@xps13>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHhsTzY3M3lVQXZkaGdHNE5rUjVTZWMxWWFxanVJV0xYN2VIOWxkMis2ZldH?=
 =?utf-8?B?RGIzaUpISjlUYXFqZDcrU083YnhtTUVEK3poQ05NQ1lOL3BXV09mVUJ2Vk5G?=
 =?utf-8?B?dGJOUmx3c1hBcGcxMWJsK0hsenp0cExQNWlYUVJwNGk1OGYraHFERHJod2Nr?=
 =?utf-8?B?bEdDYlFrSFlmUVZxUHhhaEVHajloLzE2c3VUVENFTWRORHpZR003ZnZKaUZG?=
 =?utf-8?B?MTNqTnVzK2VCZGFTWUt5SkFhSVRRVFJiek1jT3NiQlFzOGl3Y2h0U1ZPUVRS?=
 =?utf-8?B?N2svWlJPSjRubHhmQm9lNU9DUkFoVjZCN05QWFl4U0pWanF6b2pmaWp1aW5r?=
 =?utf-8?B?OVk3SlI2WWhzTXYvSzRIbGU3T25RYlhkdkxFUWNMRVNzKzFOVzBvM3RsWXR4?=
 =?utf-8?B?aWNMWjN5Y2VqbnFKOE5QdGI5TksyS2RxN0N5MmlmOUVRM3lvSlRBT0czTEtD?=
 =?utf-8?B?VkNyUGxCV3hyQTkrWExId2IrVWpTV2x1UjYyVERIajhOdkJ6MmU5bU1RVGFy?=
 =?utf-8?B?RGN1R0xSR1g4cUxGbVpTMGM5RkJxV2RncDdoTTNSL1o5MGVMRE13bjVZaEhZ?=
 =?utf-8?B?WE9QWXFTdmErOEJYM2RiT0RDYkw2NTJvQ0k1cDZlQlRtZFNVQ3V1UHA1aWhD?=
 =?utf-8?B?OHdYY21nVHI2SG1zNHppNnBpU0xIN2JnTjM2T2hJTUVEWm52K3JFd0V2MTFH?=
 =?utf-8?B?SUo2M0UveGh3UzRZdml2cmQvVzQ5MTNlcndpbEszekVmeFRwTGJVZlFkSHhU?=
 =?utf-8?B?eGNHTm55QmxGY3NYREpQK3JUckxCSHJpMG5HVmlWVGtTUU82OWFzZ2Jrb2l4?=
 =?utf-8?B?WFM0a0lxeWdSenhKbVhVSjNWNzZ5Q0hJamE1MThGRVljZXJGN1YrOTNpWlVD?=
 =?utf-8?B?R0N1V1dSaDQ5VW9WZlIzTkJ0ZWd2TDJMZGh6ckhjbWNabHVxMEcyODE4SmZ2?=
 =?utf-8?B?djhpbjRoUmNrYzJTbHhiVmZXcDFwVEtTZ0tIMTAwdTV4NFIvQXhBMUd1M2pR?=
 =?utf-8?B?SllNNkp3STdlZTNJYmJxcWdMSVZzUWtkTGQzVEN0N3NJblVQR2pMbDZCS0ZP?=
 =?utf-8?B?MDk2aHFiV2J5YkM4UFZoRk9WcmhxS0tlYnBrSjAwK3pJQVhuZTNCTHp3a3px?=
 =?utf-8?B?ak1jNFY1SU1kY0lUTi90Vkp6Y09WS1lnV1VPM1VZNWFrZDg3K01VRHA5akVM?=
 =?utf-8?B?VTV6K1Y1NzUwemVwaU52TDNRTG1ISDhOQzBkc25QazljU0pYQXdiOGtSTEdY?=
 =?utf-8?B?MkpFL0xBbktRNS9LcUJaWVhyTGdJWGVoOTVCWTRvSU5RaitxTUhGVkplSmgx?=
 =?utf-8?B?RVRYSWRQbnp5ZUhMTXZzYWtNMWFtMktVL2xWbjdMU2dJNGNJWGhmYVJPbHBn?=
 =?utf-8?B?YlE2bmswM1pTOGRIMXJNVnk3Z3RUbWZuNnNsZEZYZDE0U0JWU28vZHBDY0pu?=
 =?utf-8?B?ZUptSUxpNm05bFZhQUYrYXVDa3pHVkRiRUdkSlBKTGFoWDk4OHY1bUhKNjJV?=
 =?utf-8?B?THByUlRDRXA0dlEzSnNCMXVLcEhDMXc0dWJjdUZKWGVWekpjc3lBUlk4czMy?=
 =?utf-8?B?VlBDSC9lNmNybXdaZFY5Yjg5Nlk5c0trYU5JZDM4ZUlRbW9jMnlWYnRIRDh2?=
 =?utf-8?B?c1d5cnA1WUJJd0FNelQvei8xN091VVRhV2JUaWNiS0QwTEJJK1poT3N3WlFU?=
 =?utf-8?B?WHk0bzRPN3IyeU5nVDM4S0NnVzVJNldlK1U3S2kyM0cyd3l6S1lUMjVXU2d6?=
 =?utf-8?B?S3ZFbXdlN09jbGxOWUZpRElkTlpYUmJwUXFFS1ZhVjdldTRVKzRCYVlrOVhP?=
 =?utf-8?B?aGZCaGE4UHlKV2dPUGx4R1h1RkphWTREVUtSNW9oSHMvZndmRWh0NHh1Tzls?=
 =?utf-8?B?WGpsclZVMlM2b3RkcCtYMjE4ZFJxQ1VjeEd1OGhiYVA1aWlxTVN3dzBTN2RX?=
 =?utf-8?B?ektrdC9wanBPb3dYTWhET1JZYk4va3U4YmIxanBiczVJRUF3L0p3L1QrMERC?=
 =?utf-8?B?YW85Zkh4L1pXNTVuL3dMODlpU1QyK01LMHV0MmJxY3FPV2JMdTJwMW9KMXhZ?=
 =?utf-8?B?c3gwVVg2cmZPcXNmdmE0bXdnTytoTEJYZzd0dHRsTEFCU3gvQTBBMDBTU2Vq?=
 =?utf-8?B?Qmw1bDdQYTBpeGFtMTJ0Y1dadkRkb1JjdFRSRm0zejlKdnZNUzJCWktweUFO?=
 =?utf-8?Q?v/cG61q/6SqyjMqscmUVxlU=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9beae1d-7cc2-4904-fd4d-08d9b3f43587
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 11:26:10.3452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yh1uRafywuOpzy+3M+7VGUlLRN0rA2/ORT1cCB071j2YVz0mPq21KqpoCeHt1rP3a/2TdT99EsOXTbSmN0YixA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5393
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30/11/2021 11:11, Miquel Raynal wrote:
> Hi Jon,
> 
> jonathanh@nvidia.com wrote on Tue, 30 Nov 2021 08:53:08 +0000:
> 
>> Hi Miquel,
>>
>> On 19/11/2021 18:33, Miquel Raynal wrote:
>>> On Mon, 2021-11-15 at 11:36:55 UTC, Jon Hunter wrote:
>>>> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
>>>> compatible") added a test to check that every SPI driver has a
>>>> spi_device_id for each DT compatiable string defined by the driver
>>>> and warns if the spi_device_id is missing. The spi_device_ids are
>>>> missing for the dataflash driver and the following warnings are now
>>>> seen.
>>>>
>>>>    WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45
>>>>    WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,dataflash
>>>>
>>>> Fix this by adding the necessary spi_device_ids.
>>>>
>>>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>>>
>>> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
>>
>>
>> Please can you submit as a fix for v5.16? The commit that introduced this is already in the mainline.
> 
> Yes of course. Can you resubmit with a Fixes tag?


Thanks. I have sent a V2. I used the same Fixes tag that Mark has used 
in similar changes for consistency.

Jon

-- 
nvpublic