Message-ID: <5e4e7f69e756881a6efc1c575d74931e4ff48478.camel@linux.ibm.com>
Subject: Re: [PATCH 3/4] ima: limit including fs-verity's file digest in
 measurement list
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-integrity@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 30 Nov 2021 08:15:53 -0500
In-Reply-To: <YaWN2RPEO3fZqkv4@sol.localdomain>
References: <20211129170057.243127-1-zohar@linux.ibm.com>
         <20211129170057.243127-4-zohar@linux.ibm.com>
         <YaWN2RPEO3fZqkv4@sol.localdomain>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Eric,

On Mon, 2021-11-29 at 18:35 -0800, Eric Biggers wrote:
> > diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c
> > index 42c6ff7056e6..179c7f0364c2 100644
> > --- a/security/integrity/ima/ima_api.c
> > +++ b/security/integrity/ima/ima_api.c
> > @@ -217,7 +217,8 @@ int ima_get_action(struct user_namespace *mnt_userns, struct inode *inode,
> >   */
> >  int ima_collect_measurement(struct integrity_iint_cache *iint,
> >                           struct file *file, void *buf, loff_t size,
> > -                         enum hash_algo algo, struct modsig *modsig)
> > +                         enum hash_algo algo, struct modsig *modsig,
> > +                         bool veritysig)
> 
> 'veritysig' is being added here but it doesn't actually do anything.  It seems
> this patchset is not split up correctly.

True, this patch just adds the plumbing.  Reversing 3 & 4 could result
in including the fs-verity digest, without the signature in the
measurement list.  The alternative is to squash patches 3 & 4.

thanks,

Mimi