Date:   Tue, 30 Nov 2021 17:41:08 +0100
From:   Joerg Roedel <jroedel@suse.de>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv3 0/4] Add generic MMIO instruction deconding to be used
 in SEV and TDX
Message-ID: <YaZUJIXJC2OVFSth@suse.de>
References: <20211103154555.23729-1-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211103154555.23729-1-kirill.shutemov@linux.intel.com>
Precedence: bulk

On Wed, Nov 03, 2021 at 06:45:51PM +0300, Kirill A. Shutemov wrote:
> Both AMD SEV and Intel TDX has to decode MMIO instruction to be able to
> handle MMIO.
> 
> Extract insn_decode_mmio() from SEV code. TDX will also use this helper.
> 
> v3:
>  - Handle insn_get_opcode() in is_string_insn()
> v2:
>  - insn_get_modrm_reg_ptr() returns unsigned long pointer now (PeterZ);
>  - Handle insn_get_opcode() failure in insn_decode_mmio() (PeterZ);
> 
> Kirill A. Shutemov (4):
>   x86/insn-eval: Handle insn_get_opcode() failure
>   x86/insn-eval: Introduce insn_get_modrm_reg_ptr()
>   x86/insn-eval: Introduce insn_decode_mmio()
>   x86/sev-es: Use insn_decode_mmio() for MMIO implementation
> 
>  arch/x86/include/asm/insn-eval.h |  13 +++
>  arch/x86/kernel/sev.c            | 171 ++++++++-----------------------
>  arch/x86/lib/insn-eval.c         | 109 +++++++++++++++++++-
>  3 files changed, 160 insertions(+), 133 deletions(-)

Testing looks good here:

Tested-by: Joerg Roedel <jroedel@suse.de>

-- 
J?rg R?del
jroedel@suse.de

SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 N?rnberg
Germany
 
(HRB 36809, AG N?rnberg)
Gesch?ftsf?hrer: Ivo Totev