Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3BBC433F5 for ; Tue, 30 Nov 2021 16:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238496AbhK3QxI (ORCPT ); Tue, 30 Nov 2021 11:53:08 -0500 Received: from mga06.intel.com ([134.134.136.31]:9781 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244424AbhK3Qwy (ORCPT ); Tue, 30 Nov 2021 11:52:54 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10184"; a="297061726" X-IronPort-AV: E=Sophos;i="5.87,276,1631602800"; d="scan'208";a="297061726" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 08:49:34 -0800 X-IronPort-AV: E=Sophos;i="5.87,276,1631602800"; d="scan'208";a="601572330" Received: from vschult-mobl1.amr.corp.intel.com (HELO [10.212.122.173]) ([10.212.122.173]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 08:49:33 -0800 Subject: Re: [PATCH 07/21] ASoC: amd: Add module to determine ACP configuration To: Geert Uytterhoeven , Daniel Baluta Cc: daniel.baluta@gmail.com, Kai Vehmanen , AjitKumar.Pandey@amd.com, Liam Girdwood , Linux Kernel Mailing List , ALSA Development Mailing List , Julian.Schroeder@amd.com, Mark Brown , linux-mediatek@lists.infradead.org, Balakishore.pati@amd.com, yc.hung@mediatek.com, vishnuvardhanrao.ravulapati@amd.com, vsreddy@amd.com, daniel.baluta@nxp.com, Bard Liao References: <20211117093734.17407-1-daniel.baluta@oss.nxp.com> <20211117093734.17407-8-daniel.baluta@oss.nxp.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 30 Nov 2021 10:49:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> --- a/sound/soc/amd/Kconfig >> +++ b/sound/soc/amd/Kconfig >> @@ -96,4 +96,10 @@ config SND_SOC_AMD_YC_MACH >> Say m if you have such a device. >> If unsure select "N". >> >> +config SND_AMD_ACP_CONFIG >> + tristate "AMD ACP configuration selection" > > This definitely needs proper dependencies, to prevent asking the user > about this when configuring a kernel without AMD Audio ACP support. > > I would have sent a patch, but... There's indeed a missing dependency that was fixed in https://github.com/thesofproject/linux/pull/3284 Daniel, you may want to squash it in an update? To Geert's point, there may be an additional need to add a depends on SND_SOC_AMD_ACP There are also a set of SND_SOC_AMD_ACPyx options, not sure if any applies as a dependency here?