Date:   Tue, 30 Nov 2021 15:16:28 -0600
From:   Nishanth Menon <nm@ti.com>
To:     Jason Kridner <jkridner@beagleboard.org>
CC:     William Breathitt Gray <vilhelm.gray@gmail.com>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] counter: ti-eqep: Enable for TDA4VM/J721E
Message-ID: <20211130211628.3zxkixf6bu3mcfnx@brook>
References: <20211130193346.678544-1-jkridner@beagleboard.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211130193346.678544-1-jkridner@beagleboard.org>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 14:33-20211130, Jason Kridner wrote:
> Counter TI-EQEP was tested on TDA4VM/J721E SoC.
> 
Thanks for doing this patch,
You could drop the example - This is an example which is probably
better addressed in Documentation/devicetree/bindings/counter/ti-eqep.yaml
or in the actual device tree for j721e itself.

Instead, I would suggest to keep the commit message short:

Enable TI-QEP for TI's K3 architecture as the driver is reusable
or something of that form.

The actual devicetree dts patch should be separate and posted once the
driver support is enabled.

> Overlay used for testing EQEP0 and EQEP1:
> 
>     &cbass_main {
> 	#address-cells = <2>;
> 	#size-cells = <2>;
> 
> 	eqep0: qep@3200000 {

	[...]

> 	};
>     };
> 
> Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
> ---
>  drivers/counter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 2de53ab0dd25..453490059c88 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -51,7 +51,7 @@ config STM32_LPTIMER_CNT
>  
>  config TI_EQEP
>  	tristate "TI eQEP counter driver"
> -	depends on (SOC_AM33XX || COMPILE_TEST)
> +	depends on (SOC_AM33XX || ARCH_K3 || COMPILE_TEST)
>  	select REGMAP_MMIO
>  	help
>  	  Select this option to enable the Texas Instruments Enhanced Quadrature
> -- 
> 2.30.2
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D