MIME-Version: 1.0
References: <20211126124746.761278-1-glider@google.com> <b740b48e-2675-d324-d35c-d96f973f24e0@intel.com>
In-Reply-To: <b740b48e-2675-d324-d35c-d96f973f24e0@intel.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Tue, 30 Nov 2021 22:38:33 +0100
Message-ID: <CAG_fn=WVwh0593rX-+OwEHxEcHO9GHc-Tux=XzQs5F-T+os_5Q@mail.gmail.com>
Subject: Re: [PATCH] x86/fpu/signal: initialize sw_bytes in save_xstate_epilog()
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     tglx@linutronix.de, chang.seok.bae@intel.com, bp@suse.de,
        dvyukov@google.com, elver@google.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 30, 2021 at 10:09 PM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 11/26/21 4:47 AM, Alexander Potapenko wrote:
> > save_sw_bytes() did not fully initialize sw_bytes, which caused KMSAN
> > to report an infoleak (see below).
> > Initialize sw_bytes explicitly to avoid this.
> ...
> > Reported-by: Alexander Potapenko <glider@google.com>
> > Signed-off-by: Marco Elver <elver@google.com>
> > Signed-off-by: Alexander Potapenko <glider@google.com>
> > Tested-by: Alexander Potapenko <glider@google.com>
> > Fixes: 53599b4d54b9b8dd ("x86/fpu/signal: Prepare for variable sigframe=
 length")
> > Link: https://lore.kernel.org/all/CAG_fn=3DV9T6OKPonSjsi9PmWB0hMHFC=3Dy=
awozdft8i1-MSxrv=3Dw@mail.gmail.com/
>
> Hi Alexander,
>
> Marco's SoB entry is before yours.  Was this authored by you or Marco?
> If it was Marco, it's customary to add a:
>
>         From: Marco Elver <elver@google.com>
>
> at the top of the changelog to make sure git gets the author right.  I'm
> happy to fix it up this time, I just need to know who wrote it.

Hi Dave,

Yes, it was authored by Marco. Thanks in advance for fixing this, I'll
keep that in mind next time :)


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg