Subject: Re: [PATCHv4 0/4] Add generic MMIO instruction deconding to be used
 in SEV and TDX
To:     "Kirill A. Shutemov" <kirill@shutemov.name>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Joerg Roedel <jroedel@suse.de>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Nakajima, Jun" <jun.nakajima@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
References: <20211130184933.31005-1-kirill.shutemov@linux.intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <7fcf374d-42bd-75e3-3d14-2b8b59378715@amd.com>
Date:   Tue, 30 Nov 2021 16:11:22 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211130184933.31005-1-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlN4THNyUkx3VEVMWmlKRVNETmt4Q1dLSWp4STkyMzlvaGhoSjVxZlFnY3Fa?=
 =?utf-8?B?UWxGMmVxMG1QZ25JME5uUlM4VTRLYVMwOFMyY3pzdGtJMnlWU1RNYU1TSkd3?=
 =?utf-8?B?TVZ0ODdDemhMNWZHTWdoUS82YmUrOVpjeWxzcS9jcmN4NFhGcDUyMDN4RWpB?=
 =?utf-8?B?K3dPS2xJeDU3WldBbW5TcTRLZEsxQmt6NjBGeXlra0dKTkxVUTkvclRieGFv?=
 =?utf-8?B?bnAra3E5VnNNWVhhaGJpWlhoTlRxNDF4cFFkaCs5ZlhMQ2ltTjRSZzRwQ3Q4?=
 =?utf-8?B?NUpSZEJPUnNMbEhtYy9XV1k0ODQ5WmRIQ21lS1BXRUJMdmhTV1EwY3NSeU1E?=
 =?utf-8?B?TkNUcHphc2lNcXJPeklkMmw5ekNNRWI2N2QxYWVldWc3WXNwSlJuSmNtVmVL?=
 =?utf-8?B?NDNrSTNaUWdFb0h6YlBtbmxISUJRUmV6NHFXTnJPamZReU0vM3RMdHF6Vloy?=
 =?utf-8?B?bE53Y2M3MGEyK1dKYzdTLzRWM09ic25ScWQvazhXOERVdjhmWDlqeXRUeEZw?=
 =?utf-8?B?NjRLZXd0QkxrWFBGY1RLdnhrUi9uenNZZ2FlYzdFM3NwY0kxbWREbU1qN2Jk?=
 =?utf-8?B?RkkybW9QQkdPb0x0Vi8vK3YrUy9LSkZ5NW9ZSnV6THllNDliVHJkYlVvcHhL?=
 =?utf-8?B?ay9qc2JPQi9ZenJFK1k0eUhBOEhzVDZjcnRwb1hJNUI5SUN0ZUR0U2dEMmRx?=
 =?utf-8?B?RTJHZTJwSXV1YzBITEMvZWUwbUJ0UHJ3YWUyNURWM1ViTE9aVDZEZUJYZ2hj?=
 =?utf-8?B?MUZhVXB6TEY1RXNlWTVDNlNIdUN5Vy9qa1pMNHd6RGoyNTl2WHdTem1lRnJC?=
 =?utf-8?B?RWkwZ095aGhEa1hVYnE1L1F0RFUvZmREUjlzbHJ1Z1hGSUVuc01vNmpSS09Y?=
 =?utf-8?B?eHk5UWtudFcwNVNNenhYUkR2ejlTb0NJa0h2VmNHZ3ZIRi8vcFNZVWE1YVdh?=
 =?utf-8?B?Zm9rYTI3UVNycXVhQjNTQ0lmQjVXRGcwVmJrakFLZGtRc1hiQmNuNGExdHpn?=
 =?utf-8?B?cXFmM1FlcFdMbCszY1lxYXRsZnBtUmdQT2ZwQnNmeGFLSUgxNWxPT25vdUll?=
 =?utf-8?B?L2JZZVkxdmQ1UGoxMXZGVlFjRHF4RjE2bEpSZ1cvTTlXUWxpTktZdnJQSHor?=
 =?utf-8?B?UjBjcDRFeGprTGVidGkwcDZva0ZZNjMxWUdjUXNhS0NYWTVDK0RtYjBkOGU3?=
 =?utf-8?B?OTk0MTV4dUtQUWpaTlpLRTVTTTYzS1NPNVp5akVwcTZXM3ZZVDRXV01QTkZz?=
 =?utf-8?B?OE1DVk9qeWpFd05PSk9YV0xMM0ZCNFRTNXpnaHJXeG50V2hhRE0weDJMVmpT?=
 =?utf-8?B?UUg3NHE3elJIY2xzbEdsaUV3YUFmcC9qZkhVWWZwcHhFaGRyTm9WMkNla2M0?=
 =?utf-8?B?NGJMWGNoTEd4ZitaVFdIQ0hMdW1jVzJLQXZ6QUlWdklWOUhmV1FMeEVIZ2VT?=
 =?utf-8?B?UVdUd0lFVzNOMFJlTlpJSUtWYzRhTlNxaTVwYUsvT1FhTm5DcE5WQWgvNUha?=
 =?utf-8?B?amVZRHVTYUhUOGJkVUswWlY2emt0bGVITG1VNVRETitiQU02Y2hsMzhacGwx?=
 =?utf-8?B?bFVTVXZmZXhwTE54WTEzdDZiaGxWbU1zbFU3clZmdktqWXZMYVNzL1FiQWV4?=
 =?utf-8?B?SHh5ZG9LTFl1RGJIWDBxQ0ZKUXRnYUpVNm1pYXUvRVRjaFI3Tjc2VXppRnlv?=
 =?utf-8?B?TjhNcGRpcmtTc2pNSDdjb0ZLQno3QSsvL3lsbG84Vmt6Ujl0c0xsY2d5ajFa?=
 =?utf-8?B?ckMrRy9TdDJsU2R0b2kzTTI2UXdkNjZmenpuenI2ZVhNMklwR2VSbStXc2NV?=
 =?utf-8?B?eTd2WFJCNEhBbTdTZDJmMmdOYkRrV2wwbXFYZk81SDhvTGluNW1WTGY5T1pD?=
 =?utf-8?B?NEM0NlFuMGhINTZQcndtaklHL0pRUjNwd3JRam5DbHBMbVA2em80TXBBclFt?=
 =?utf-8?B?cm1DemF0TzhBQ2ZHTnNXK29OWmhiWWw0Y2pETWE4TXM0cllWU3luTGtwcVNJ?=
 =?utf-8?B?VytNdGVBSytNWnljQTgyYjdBVVo3b0dQNGoweXBLaXJLbTJOWjNSMHVVTDFq?=
 =?utf-8?B?TjdXT0V2dTZNQnp0empxQk5IUjJGajlDbzFTYlFJdHZGNUVUSlBrd1grU3Z2?=
 =?utf-8?B?NTdIR1lHK1YrTjJKYWdBZjYyNGIyMHZGUmJjbFVOaTl5cmZ6dWY2Q3l6S2lr?=
 =?utf-8?Q?4TjHFwUdGedHeq8B0Fo6qyw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5db8c883-e8af-40fe-c9d3-08d9b44e59e4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 22:11:26.2691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SKnGucuhrko8c7KJRuuYGYFw6rfODuv4+x4WgYlm61IpooQBpf5PBfCYmbrqdLSn3xHnDJkx+ppDljI2TyzlZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5341
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/30/21 12:49 PM, Kirill A. Shutemov wrote:
> Both AMD SEV and Intel TDX has to decode MMIO instruction to be able to
> handle MMIO.
> 
> Extract insn_decode_mmio() from SEV code. TDX will also use this helper.

For the series:

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> 
> v4:
>   - Use enum mmio_type inside insn_decode_mmio() (Tom)
>   - Keep a comment in vc_handle_mmio() (Tom)
>   - Tested-by on AMD HW from Joerg.
> v3:
>   - Handle insn_get_opcode() in is_string_insn()
> v2:
>   - insn_get_modrm_reg_ptr() returns unsigned long pointer now (PeterZ);
>   - Handle insn_get_opcode() failure in insn_decode_mmio() (PeterZ);
> 
> 
> Kirill A. Shutemov (4):
>    x86/insn-eval: Handle insn_get_opcode() failure
>    x86/insn-eval: Introduce insn_get_modrm_reg_ptr()
>    x86/insn-eval: Introduce insn_decode_mmio()
>    x86/sev-es: Use insn_decode_mmio() for MMIO implementation
> 
>   arch/x86/include/asm/insn-eval.h |  13 +++
>   arch/x86/kernel/sev.c            | 172 ++++++++-----------------------
>   arch/x86/lib/insn-eval.c         | 109 +++++++++++++++++++-
>   3 files changed, 161 insertions(+), 133 deletions(-)
>