MIME-Version: 1.0
References: <20211130143526.1820249-1-mudongliangabcd@gmail.com> <20211130145056.GZ18178@kadam>
In-Reply-To: <20211130145056.GZ18178@kadam>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Wed, 1 Dec 2021 10:02:44 +0800
Message-ID: <CAD-N9QVt-5NepnmG-9ywo+JsO4PWOO1jLQ-_=cL=PFNKHYR=CQ@mail.gmail.com>
Subject: Re: [PATCH] driver: pmc_atom: free pmc->regmap in pmc_setup_dev
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 30, 2021 at 10:51 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Tue, Nov 30, 2021 at 10:35:25PM +0800, Dongliang Mu wrote:
> > Smatch reports:
> >
> > drivers/platform/x86/pmc_atom.c:496
> > pmc_setup_dev() warn: 'pmc->regmap' not released on lines: 496.
> >
> > Fix this by deallocating pm->regmap.
> >
> > CC: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
> >  drivers/platform/x86/pmc_atom.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> > index a9d2a4b98e57..95ba108ed716 100644
> > --- a/drivers/platform/x86/pmc_atom.c
> > +++ b/drivers/platform/x86/pmc_atom.c
> > @@ -492,6 +492,7 @@ static int pmc_setup_dev(struct pci_dev *pdev, const struct pci_device_id *ent)
> >               dev_warn(&pdev->dev, "platform clocks register failed: %d\n",
> >                        ret);
> >
> > +     iounmap(pmc->regmap);
>
> This releases it on the success path so it will break the driver.

Yes. I should only deallocate it in the failure handling of
pm_setup_clks. Will modify it in the v2 version.


>
> regards,
> dan carpenter
>
> >       pmc->init = true;
> >       return ret;
> >  }
> > --
> > 2.25.1