From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Felipe Balbi <balbi@kernel.org>, Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Cai Huoqing <caihuoqing@baidu.com>,
        Tao Ren <rentao.bupt@gmail.com>,
        Julia Lawall <julia.lawall@inria.fr>,
        kernel test robot <lkp@intel.com>,
        Sasha Levin <sashal@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
Thread-Topic: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
Thread-Index: AQHX5d7cQ2+vsTwu+0+N7TayZq2xGqwb8xUAgADyF5A=
Date:   Wed, 1 Dec 2021 02:09:43 +0000
Message-ID: <HK0PR06MB3202E90BCA3BC31D6E4C752480689@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20211130113847.1405873-1-neal_liu@aspeedtech.com>
 <20211130113847.1405873-2-neal_liu@aspeedtech.com>
 <YaYOPgzv6hGyXLYg@kroah.com>
In-Reply-To: <YaYOPgzv6hGyXLYg@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G9ezM6WQq6YeVMjkt8T3mc5t7gDrwoBm0hVi2XUJPR7ITGA760UoR7KlO7iK?=
 =?us-ascii?Q?15RAx63RQSs1ib9LlkUodrEOpRERwFLjTvyzaPnfOmZ70TflJEbSZ/TWXi4y?=
 =?us-ascii?Q?GbRLHBCyKLQOMOCKARvzeXWatt5Ozq6ti4IEZOceqveHx6vMn/VuvDiGFwFw?=
 =?us-ascii?Q?jvOObL6OTcytYBbfB1EOCxV1aJqY6A+dDGvgg9zkkj/lTBPMe1gM6ebAtBk+?=
 =?us-ascii?Q?2Qvqn9EcGUP82TF3CYH1dk9+7NLtBRgUs8MR3wPPSF0+vCqs+0ercVWQ8FSC?=
 =?us-ascii?Q?N7MI4k4/TgZ7zPdPG5ikjLUjgCDJ1cvAw9na2bsRlfAQse17eBxaS99SIbol?=
 =?us-ascii?Q?cAc4iJVf9t/fcTyFk4euGVAYSMUasejIoJitWa/n+hWmo1Mz/bWKZxPWCAH7?=
 =?us-ascii?Q?2IFVFH/RGF7lzfJXjuzQx4pgBA7u8rs0M5ZNE65yJIHK0H69NbVlH5Dl4JBn?=
 =?us-ascii?Q?UyHayvgmhIqa9YM/rhX0jSOTX9++DcXOKlUZqzTtvg2vcf6uFW1PTnQ8pPBF?=
 =?us-ascii?Q?vJSp8eJ1lTbb302N4/yhhj7QehUkFLvoac4Xs7uEnl73GsK9Yct18a5sHx6r?=
 =?us-ascii?Q?SpCSv2x6EOC7EQCBzDNnjGKSsKk8EN30RYkKxWl7wsZgemHy++8IM6lSsoHZ?=
 =?us-ascii?Q?neUTJjzSEuwVfQrta8nyuJgVyZH4mSQfRyyhu49MLcdfdhmbtOUBuZmrZOoI?=
 =?us-ascii?Q?J2Q/Vq0wH3TIs89pT60QgXExBZls2yhh4IMf1eEzK34awvrw9JD33gWHfEHr?=
 =?us-ascii?Q?ADuFe3TBD3orR6+LWZ1oQDLiDgXfmKOtS1i7NU4iTpAHb9hgghiO8CqAQUAS?=
 =?us-ascii?Q?jRWAl1a/rdQxS9LEUyff47pS+yzUuBn8unorZi9yFd3vMG33rlGTt5YWfmEv?=
 =?us-ascii?Q?kpREA12bM6tO32KWiUjJOMvclC8TIm5Zv4ueRi5WoMMM8EMIg7or3Ipzt4ge?=
 =?us-ascii?Q?JDo/JfvTw1sn0BudEtZLOZ74KbdJ7l2W3OHU7041kpyO3SNpgsL+7tA7wfUN?=
 =?us-ascii?Q?7w/xbqp+ZNKE0aFZMCVL1pirjAN3q0MfCbOEDtfZvHa/Z3y5rq5kqLus6h2n?=
 =?us-ascii?Q?mLc9zIJ2Awx2u2YQwl8B69Dkm0KQQF+uHtow5lCl8gZmes//bkcDa2WZ+Yk3?=
 =?us-ascii?Q?ava9VWWCLmXDLDnGfve7p6O8pm1YUM9qRptvvELw6qigFJ998v2CS5sfQuvI?=
 =?us-ascii?Q?2f1rh0OLHDe2PeJxNwZLQMMMHIezumf0Q4iOiE8N6aX5liyAuqcFWu94dHvP?=
 =?us-ascii?Q?am6thgDw+2bIsXrnlFqoplsh2xvtjGP3IlhLaGdIAK61DFwfpcWNsIY2pnFA?=
 =?us-ascii?Q?M2lZhJ66jTkFd+NmVfaCeiPKYfUUP2KK2tGW/yx5klPfFKxdeXckhvgBqOJx?=
 =?us-ascii?Q?P8l7tFaPmWs8afg2KA+ltxvL85+YeGreCLZ/jRwnsh73X+gS/3KHMtx+WnR1?=
 =?us-ascii?Q?Uhb9yF0HS3d07TVQfupZHQ5Kq1A/8ytx9Je/jMhlzuG3vufXuqXa7CVnppp8?=
 =?us-ascii?Q?qBUMHMKUbOdv+SJK/nD/8zcgOVYVJAJpxv7X3zCHEmnlc8Qv78M6ku0DUTB+?=
 =?us-ascii?Q?G1ylx4iu+RrIQOQFAvyNQHTW1AoDbcWKH85aryhqWMPOcRf3nOilax6NpK5K?=
 =?us-ascii?Q?NzhRxuXMQmtAvPHaGV4VgmI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d4e8627-6d1a-4b41-f0dd-08d9b46fa41e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 02:09:43.5837
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2cN299zZ8878M5pN29QXEeoXYO+ZR9nHLUeksenLWFEfVKNu6DFShBVAhcadINoe7uA9/e5+GG+mLwlwDeCgEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3203
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Tuesday, November 30, 2021 7:43 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andre=
w
> Jeffery <andrew@aj.id.au>; Cai Huoqing <caihuoqing@baidu.com>; Tao Ren
> <rentao.bupt@gmail.com>; Julia Lawall <julia.lawall@inria.fr>; kernel tes=
t
> robot <lkp@intel.com>; Sasha Levin <sashal@kernel.org>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> benh@kernel.crashing.org; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
>=20
> On Tue, Nov 30, 2021 at 07:38:44PM +0800, Neal Liu wrote:
> > +Ben.
> > ---
> >
> > Support qualifier descriptor to pass USB30CV compliance test.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
>=20
> The way you wrote this means that everything below the first --- line wil=
l be cut
> off if it were to be applied.
>=20
> That is not what you want.
>=20
> Please fix.
>=20
> thanks,
>=20
> greg k-h

Yes, I'll fix it. Thanks

-Neal