Subject: Re: [PATCH -next] staging: rtl8192e: rtllib_module: fix missing
 free_netdev() on error in alloc_rtllib()
To:     Pavel Skripkin <paskripkin@gmail.com>,
        <linux-kernel@vger.kernel.org>, <linux-staging@lists.linux.dev>
CC:     <gregkh@linuxfoundation.org>
References: <20211130034007.779351-1-yangyingliang@huawei.com>
 <851b57b9-79ac-e7a1-a61a-6f36a5d9d77a@gmail.com>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <8f1c4e5a-663f-e5f4-a98e-b72ee3a4f365@huawei.com>
Date:   Wed, 1 Dec 2021 10:41:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <851b57b9-79ac-e7a1-a61a-6f36a5d9d77a@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi,

On 2021/12/1 2:57, Pavel Skripkin wrote:
> On 11/30/21 06:40, Yang Yingliang wrote:
>> Add the missing free_netdev() before return from alloc_rtllib()
>> in the error handling case.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>>   drivers/staging/rtl8192e/rtllib_module.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtllib_module.c 
>> b/drivers/staging/rtl8192e/rtllib_module.c
>> index 64d9feee1f39..18d898714c5c 100644
>> --- a/drivers/staging/rtl8192e/rtllib_module.c
>> +++ b/drivers/staging/rtl8192e/rtllib_module.c
>> @@ -125,7 +125,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
>>         ieee->pHTInfo = kzalloc(sizeof(struct rt_hi_throughput), 
>> GFP_KERNEL);
>>       if (!ieee->pHTInfo)
>> -        return NULL;
>> +        goto failed;
>>         HTUpdateDefaultSetting(ieee);
>>       HTInitializeHTInfo(ieee);
>>
>
> Good catch!
>
> There are 2 more possible leaks, tho. rtllib_networks_allocate() and 
> rtllib_softmac_init() should be unwinded too.
The error path of rtllib_networks_allocate()  won't leak the dev.
>
> For some odd reason rtllib_softmac_init() does not return an error in 
> case of allocation failure, but it should be fixed. I think, it worth 
> to fix whole error handling in one patch
I will send a v2 to fix this.

Thanks,
Yang
>
>
>
>
> With regards,
> Pavel Skripkin
> .