Date: Wed, 17 Jan 2007 11:21:15 -0800
From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: grundler@parisc-linux.org, akpm@osdl.org, greg@kroah.com,
       kaneshige.kenji@jp.fujitsu.com, linux-kernel@vger.kernel.org,
       seto.hidetoshi@jp.fujitsu.com
Subject: Re: patch pci-rework-documentation-pci.txt.patch added to gregkh-2.6 tree
Message-ID: <20070117192114.GB14485@suse.de>
References: <20070116222721.EA942B41673@imap.suse.de> <45ADE7CB.2080701@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45ADE7CB.2080701@gmail.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1024
Lines: 28

On Wed, Jan 17, 2007 at 10:09:08AM +0059, Jiri Slaby wrote:
> gregkh@suse.de wrote:
> [...]
> > +Tips on when/where to use the above attributes:
> > +	o The module_init()/module_exit() functions (and all
> > +	  initialization functions called _only_ from these)
> > +	  should be marked __init/__exit.
> > +
> > +	o Do not mark the struct pci_driver.
> > +
> > +	o The ID table array should be marked __devinitdata.
> 
> Is that correct? It panics somewehere IIRC?

If it's marked __initdata it can panic if we try to access the data when
adding a new PCI device after the system is up and running (pci hotplug
or dynamic pci ids support.)  That's why it needs to be either no
marking or __devinitdata (which resolves to nothing if CONFIG_HOTPLUG is
enabled.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/