Date:   Tue, 30 Nov 2021 21:28:33 -0600
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Doug Anderson <dianders@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
        quic_ppratap@quicinc.com
Subject: Re: [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy
 nodes for SKU1 board
Message-ID: <Yabr4azUasmQDy7U@builder.lan>
References: <1637837815-8532-1-git-send-email-quic_c_sanm@quicinc.com>
 <1637837815-8532-3-git-send-email-quic_c_sanm@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1637837815-8532-3-git-send-email-quic_c_sanm@quicinc.com>
Precedence: bulk

On Thu 25 Nov 04:56 CST 2021, Sandeep Maheswaram wrote:

> Adding USB2 controller and phy nodes for SC7280 SKU1 board.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 9b991ba..ffd483d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -80,3 +80,19 @@
>  		qcom,pre-scaling = <1 1>;
>  	};
>  };
> +
> +&usb_2 {
> +	status = "okay";
> +};
> +
> +&usb_2_dwc3 {
> +	dr_mode = "host";

The commit messages doesn't capture why the mode changes from peripheral
to host.

> +};
> +
> +&usb_2_hsphy {

Is this specific to this SKU? Is there a reason not to keep this in the
dtsi?


Please squash the two patches and please write a proper commit message.

Thanks,
Bjorn

> +	status = "okay";
> +
> +	vdda-pll-supply = <&vreg_l10c_0p8>;
> +	vdda33-supply = <&vreg_l2b_3p0>;
> +	vdda18-supply = <&vreg_l1c_1p8>;
> +};
> -- 
> 2.7.4
>