From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Felipe Balbi <balbi@kernel.org>, Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Cai Huoqing <caihuoqing@baidu.com>,
        Tao Ren <rentao.bupt@gmail.com>,
        Julia Lawall <julia.lawall@inria.fr>,
        kernel test robot <lkp@intel.com>,
        Sasha Levin <sashal@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
Thread-Topic: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
Thread-Index: AQHX5dcPGG2zpqcQlU+Dys+5o778UKwb870AgAEqPKA=
Date:   Wed, 1 Dec 2021 05:43:16 +0000
Message-ID: <HK0PR06MB3202436CA49363FD3F60212380689@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20211130104256.3106797-1-neal_liu@aspeedtech.com>
 <20211130104256.3106797-2-neal_liu@aspeedtech.com>
 <YaYOvgCaO4FJ8r+z@kroah.com>
In-Reply-To: <YaYOvgCaO4FJ8r+z@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I87LySCuvXwFkQhREjwsNxoVKvVIkGxqMKZfbi5VtNbONzhhoiY5DcV/wjSL?=
 =?us-ascii?Q?nWV9BTWyhUFJVAlzU5Xjl2cM3UZ24qw7RKQt5qr0TePcEuC4dtRLVM5YI/WX?=
 =?us-ascii?Q?lCezVXTve6Pj+BQV9vW7rLAXqjGgv0VtoUQLtJWe0/uFmIxwaGXTOANWBXbk?=
 =?us-ascii?Q?Zc3eWMe6IhEGgSitt/iTe3P01GLW8NJefQIvGgZ32dTjtphAuPNF0p3Goez/?=
 =?us-ascii?Q?SgIxXgjWwSXf73Ic/X/mAc1Rpt6w62wVow+bi20pveXdr2tB3Tp858RFhijv?=
 =?us-ascii?Q?rykE7qIuj/lfGa/y5UZhQtDoagrW+C1Y6I3F90Z5sbgtePgWPb4chs4t7n3N?=
 =?us-ascii?Q?0pPravMScCjPz+npnKJW4ZdTZsCQR6q0umJ63s/uoqYHsfvW6aYVs+dznS2n?=
 =?us-ascii?Q?Mi88kS8ktQNV8hgsHFbORXbPRsAc1ozWdBi7Yge0nJBbQBPYoYV52pC+tSuJ?=
 =?us-ascii?Q?9pNSiLJbR5bLH/zsxmsXrvfJt3Kz1SK6+EsIgQwZ2q2m3c3GpzMRkuAvtEWJ?=
 =?us-ascii?Q?wzp0A46E0hj8jL4tRyXkiH9dWt4DSbjKOWgr6AiyDoDv5RORem4oGTW4T56Y?=
 =?us-ascii?Q?alZxYO3eR9DIm6Hwk9h1UiO9uEn34uQWPQmtQRZP1FKSCsA9uOiUprkKhKTb?=
 =?us-ascii?Q?AKzc/kQgC16QRDYqLojTl2tZft9ASNjYc3zBOyz879x7Dkr+UPh/srKtBkDD?=
 =?us-ascii?Q?T0bIQxCECjV3+ATOsl0c7ySumvMQ0aEiakM0GDXUiAWLVK7NWfTGBO9vGtRc?=
 =?us-ascii?Q?s+zRarqtuBMqedbLGDarfkgjXDFC/QrvaOP/BEb1on+ozejguYERmtBOPYJQ?=
 =?us-ascii?Q?zyVcS5jxqjZjTUJjowL74wzWCq2krf9KgF20DIVXuGHhzJzDD4fNxYerVMiH?=
 =?us-ascii?Q?6tVnq+1f728xrCuYyVzbhNjqdv8C+EkVWbyMjwwoHThP+8hVaCAOVayd2b3v?=
 =?us-ascii?Q?huIKsdaNi9EiElnkRYcTYPovG6sBdV7sKIbeQh57FxS0KnQyVDQgBGi2tv1B?=
 =?us-ascii?Q?0kby3rdtpnQ/r3pgmABhytEvoumToKyPJ+doxZNyHldB/42FHkwCUTn4yxoL?=
 =?us-ascii?Q?rL7bcmv8v/nt4292YwO9jNRNFipByjkQs/moVLPSkJbd3MD+QrVajj07Xedy?=
 =?us-ascii?Q?fb0nHrASlg5tRNDJGR8/dZz+NY+w++Tuq31GBnSxRMgcs7Wupn5s3xQvh5fV?=
 =?us-ascii?Q?dnXkq8ZH68tnFN6WLwdJkMtYAuk4tY8VL6GWDA595j3oTMCuWhYWZ6swt72E?=
 =?us-ascii?Q?zVjqeuw4gu4gFDRRK6RO3ICY8PFdoaUVUVCPFnhkkuhMCPrUqFnQEtLE0eQZ?=
 =?us-ascii?Q?UUMC9QUzNZ1jK6t39pyMw08B429wAVpxCcpSYKc5YYOuLcRnsOg6b3opU2fw?=
 =?us-ascii?Q?hkdF0urtZG6YojJNZzqdIF7P5/ERER8Sc/JPDD8wVo2QtUQL7N/btaFLBYbr?=
 =?us-ascii?Q?QeGL3DZtKD65RQ0sEHhpG7YHaP8Sbh4pPvqQFBZVoi55wbRw9wL+HYN2dK6L?=
 =?us-ascii?Q?P30Y0S33wfzcgqjMfugsoYkIxYDBdvBKXMVpq+GAE3AxlRzaF5SqycfD4V5V?=
 =?us-ascii?Q?VmC/xEkycEF2takDiC2o5aPFbnOVsqcx/gpX+jttzKNQKFRDE3GbfNHvStnW?=
 =?us-ascii?Q?5FPKG5W4f0j3OW4OCF5eJxs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d61017c3-31c6-477a-7754-08d9b48d792e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 05:43:16.4983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KRK6AaQXNdiO1D4YgDN8oi53p9vYZKQgzMcm8Js4AookgRLgPK6oK3W6fvum5POLf5lOLhPHunsKs1fTnkMbrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3377
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Tuesday, November 30, 2021 7:45 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andre=
w
> Jeffery <andrew@aj.id.au>; Cai Huoqing <caihuoqing@baidu.com>; Tao Ren
> <rentao.bupt@gmail.com>; Julia Lawall <julia.lawall@inria.fr>; kernel tes=
t
> robot <lkp@intel.com>; Sasha Levin <sashal@kernel.org>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; BMC-=
SW
> <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
>=20
> On Tue, Nov 30, 2021 at 06:42:53PM +0800, Neal Liu wrote:
> > Support qualifier descriptor to pass USB30CV compliance test.
>=20
> Please provide more information here in this description.  This does not
> explain what is happening here very well.
>=20
> Also, what is "USB30CV"?
>=20

USB 3 Command Verifier (USB3CV) is the official tool for USB 3 Hub and Devi=
ce Framework testing.
The USB3CV tool includes the xHCI Compliance Drivers for use with the USB3C=
V.

We would like to pass USB3CV - Chapter 9 Test [USB 2 devices] - Device Qual=
ifier Tests.
A high-speed capable device that has different device information for full-=
speed and high-speed
must have a Device Qualifier Descriptor.
This patch is to support device qualifier, and the host will retrieve it th=
rough Get Descriptor request.

> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  drivers/usb/gadget/udc/aspeed-vhub/hub.c  | 24
> > +++++++++++++++++++++++  drivers/usb/gadget/udc/aspeed-vhub/vhub.h |
> > 1 +
> >  2 files changed, 25 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> > b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> > index b9960fdd8a51..93f27a745760 100644
> > --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> > +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> > @@ -68,6 +68,18 @@ static const struct usb_device_descriptor
> ast_vhub_dev_desc =3D {
> >  	.bNumConfigurations	=3D 1,
> >  };
> >
> > +static const struct usb_qualifier_descriptor ast_vhub_qual_desc =3D {
> > +	.bLength =3D 0xA,
> > +	.bDescriptorType =3D USB_DT_DEVICE_QUALIFIER,
> > +	.bcdUSB =3D cpu_to_le16(0x0200),
> > +	.bDeviceClass =3D USB_CLASS_HUB,
> > +	.bDeviceSubClass =3D 0,
> > +	.bDeviceProtocol =3D 0,
> > +	.bMaxPacketSize0 =3D 64,
> > +	.bNumConfigurations =3D 1,
> > +	.bRESERVED =3D 0,
>=20
> Fields that are to be set to zero do not need to be set here, the compile=
r does it
> for you.
>=20
> thanks,
>=20
> greg k-h

This is more clear that we specify each member's value.
Thanks

-Neal