From:   "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Senthil, Bala" <bala.senthil@intel.com>,
        "N, Pandith" <pandith.n@intel.com>
CC:     "Saha, Tamal" <tamal.saha@intel.com>
Subject: RE: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode
 Plus and High Speed Mode
Thread-Topic: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode
 Plus and High Speed Mode
Thread-Index: AQHX1VWadmPN2CWbpkS9Sg6fkPAU8awa2Y+AgAD5/wCAAW+RsA==
Date:   Wed, 1 Dec 2021 05:51:58 +0000
Message-ID: <DM6PR11MB36609A77B3F5D7730FA16A52C4689@DM6PR11MB3660.namprd11.prod.outlook.com>
References: <20211109103552.18677-1-lakshmi.sowjanya.d@intel.com>
 <YaUGV3lEmW9qtP+3@kunai>
 <042d2c9f-4333-44b1-09c0-b0953a51c176@linux.intel.com>
In-Reply-To: <042d2c9f-4333-44b1-09c0-b0953a51c176@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.200.16
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QJu+RrzgogxL7nQ6MHJBehzbHZ+8OkRxYiNg/VzQx7vHAGz7eCwxXM9iujfH?=
 =?us-ascii?Q?KoAVRPbb0RgiM9rLHa/qpWhVTlxt3pfI/P+KAzEI0dPk1ez1xxFmO5PqtdB/?=
 =?us-ascii?Q?J/ct7CFR/sO63pLNQLNVvcZDPsbVtN33fl7il2WVNIwZTIs6BH6POqy6U+CR?=
 =?us-ascii?Q?Y47tbHlSnj6ZlTwq5X2XnMBg+fKJMtxn9O1R2FFYRqika5Z7mtKArxOdCpY5?=
 =?us-ascii?Q?Qnpa7GgKA9gMBVWopuRXyOCgDp+KKHqOAqD2CekqXmUIIrj2CGr8GDfiEVY+?=
 =?us-ascii?Q?mrnALHcLX5Ef1Q5W60WM1BHyfjhDC6SSJKf6aCf7TPZnZVxfM5lcwiC8VZHl?=
 =?us-ascii?Q?xQ60TFwqQkmwxXGHMFnFMh/mv87lgcHrOneTDsSYDGLlcpI4nM/VXSVVy7+x?=
 =?us-ascii?Q?+sh/20AZqw8lufE1EihSCgFgxOXfXsQ9FNLwomkV7m0imbEImWyu2mfD82J2?=
 =?us-ascii?Q?UmxAEp9fvhqZA7C1bQZ+mSJlB6/7GRRn8GeuKBsdrqiVUXWhNCeLZRruwe+Y?=
 =?us-ascii?Q?9tcYwackBRcLhIMmTp9R/s7veDzPL64Vcedmu3G0HZ2jejO3oOsB/LRUWego?=
 =?us-ascii?Q?QDOB8zlUDF4Kcx/eh7GPObWjcXFOCuFUxcY3wHC+dy0U9pR25RtGOvMbR13D?=
 =?us-ascii?Q?b0h+8Chta8/BJiFiLQyfW83HGup96dH9blIsQRmVJPBSRizGVxd3cny2s0q/?=
 =?us-ascii?Q?RvsV9moH22OBQDZoj1g/nykEVjP7FXu8uV5t3Mm9XaT4cJRJnpdMQ3PWnWlp?=
 =?us-ascii?Q?C42z+QzRXf2FQzlzle5TYH8D+phb/bM44mUvbOrvOL3A/kB+ErcoP2TLu4S2?=
 =?us-ascii?Q?wwrteRHksVuCUIEY5u3Etx3PFHrOIJqS+IBJWEFFQZvhKWe6VpCL6kpTkK8/?=
 =?us-ascii?Q?kHJjiUEexnzqkRvXI05SWk5Qoo7xUJXPvGveFxJ2lDjuaXgKuWn4J4R7L6OO?=
 =?us-ascii?Q?Q3DHARoCua1UQ5gZRsyz62+O5zoinwzl56xX1TmKgMjWAyw10YNwHx/K5Qo8?=
 =?us-ascii?Q?OM+6XUZWozpfC0PrEpIKge96mui6btT7tDh03T2RY2gxzwP5ZsqaAie6weLo?=
 =?us-ascii?Q?cO+/+iEiLx1cUtAFf063bGphGy7743pIo/bJHLUfCr1VBN3+y93dTUrSQRiF?=
 =?us-ascii?Q?7XgSLTeeGPisyL1SuysyHWa74/sK/lGP41KsqX/0kmxiX+iUlJ9jnmFQ9Tiw?=
 =?us-ascii?Q?RPAvQpW+1pzZ1FERQn1lEke5T6uKNjijV4d5OE9aFaoa+nxmEiWmn6wkBb4a?=
 =?us-ascii?Q?wnlEWFAEf4t8iaT9lTUdGBq3TI9WkVMpFC+XnHkPRY3xA0mYEaqOPrPRqyd2?=
 =?us-ascii?Q?2BqmAmxan55NhxmokU18IdQz6AtqKPPEeYlXJdTRK/qkjzEDMohlwOYqklSp?=
 =?us-ascii?Q?Oee5anb/qEltXObVjrAqc/Ltk9QdQz8yxkhOIPeToFoFElJmWHm4rN+HMwee?=
 =?us-ascii?Q?A6wGveYiUtP7/2oEsPqfsijTPCkVDuzqowktM0zmpUUO/xxaL+VWupNf1zkD?=
 =?us-ascii?Q?MlCsMSSQD1yBb24Q78wQ7afHS5gOf/lJJlw7vZHUGTwypo7QIZdS9hQi5TKq?=
 =?us-ascii?Q?Np8LSHQl8UTjC7K4ATmSa7ywFuQwd9u61m18QruUOtGV2hRmH0JuCR80brOR?=
 =?us-ascii?Q?0ryytLafDVLaZ6ugbwoh9EubpEOFL9GOJt6t2FM+p6YtiSuuuIhdHUtrSqHx?=
 =?us-ascii?Q?B4Cs6A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c5c119a-d270-454b-665d-08d9b48eb07c
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 05:51:58.8134
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LdPhbtPDxiv42utl3Kk1y18dgCEPIOF8ZPp9FhBvh8YDi3Y6kEEpFFEVS5KNOry2pC9zNW+FhOIJ6iv6hug/3LGTajrRd2uaMjep9CH5SVU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3244
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>Sent: Tuesday, November 30, 2021 1:22 PM
>To: Wolfram Sang <wsa@kernel.org>; D, Lakshmi Sowjanya
><lakshmi.sowjanya.d@intel.com>; linux-i2c@vger.kernel.org; linux-
>kernel@vger.kernel.org; Senthil, Bala <bala.senthil@intel.com>; N, Pandith
><pandith.n@intel.com>
>Subject: Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode
>Plus and High Speed Mode
>
>On 11/29/21 6:56 PM, Wolfram Sang wrote:
>> On Tue, Nov 09, 2021 at 04:05:51PM +0530, lakshmi.sowjanya.d@intel.com
>wrote:
>>> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
>>>
>>> Add support to configure HCNT, LCNT values for Fast Mode Plus and
>>> High Speed Mode.
>>>
>>> Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
>>
>> Applied to for-next, thanks!
>>
>>> +	u32 fp_lcnt;
>>> +	u32 hs_lcnt;
>>>   	u32 sda_hold;
>>
>> Short question unrelated to this patch. Why are all these u32...
>>
>>>   		dev->ss_hcnt =3D cfg->ss_hcnt;
>>>   		dev->fs_hcnt =3D cfg->fs_hcnt;
>>
>> ... and the ones in dev are u16? Wouldn't it be easier if they all had
>> the same type?
>>
>True, only sda_hold(_time) is u32 and other timing parameters are u16.
>
>Lakshmi: Would you like to send a patch fixing this and get more contribut=
ions
>to the driver :-)

Thanks Wolfram and Jarkko,

Sure. I will send a patch fixing it.

Thanks,
Lakshmi
>
>Originally this discrepancy was introduced 2014 by the commit 8efd1e9ee3bd
>("i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value").
>
>Jarkko