Date:   Wed, 1 Dec 2021 10:04:57 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        gregkh@linuxfoundation.org, paskripkin@gmail.com
Subject: Re: [PATCH -next v2] staging: rtl8192e: rtllib_module: fix missing
 free_netdev() on error in alloc_rtllib()
Message-ID: <20211201070457.GD9522@kadam>
References: <20211201062908.1656422-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211201062908.1656422-1-yangyingliang@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QjqT7BpKAPFseQiqSj3ZRsz0hM1m6Cu2gKVBqqGEaBx4rP3p6IyrKVAHpu7t?=
 =?us-ascii?Q?Mo9XifNsj5a8wIt59OX4rZzymh8ca4IzEUH4IMe1onudZKcR0I/or/VJxg2E?=
 =?us-ascii?Q?+urE8ISK2baWnI29ntd2uGto5oOEc8/uNgaYcpoUEh9FgBm20Wfcprl07omB?=
 =?us-ascii?Q?gV8xpoUmVAIerg2eaO7DDyzrDRCmp2gU3w4b8Z+Asn+h+da+n8K3Ea50tIKE?=
 =?us-ascii?Q?ZSAINPeQPSi4IXXVoAq7Ej0srLT/eTq/R+un5SlyPzuB4DVS4bLQuUWlQL9M?=
 =?us-ascii?Q?Hly1u+aQYPsaELyB4cZs2R9OHfF8j3HwtoExh6s3OQ5iznYpELJFjiR+UBxq?=
 =?us-ascii?Q?cS73tvrk+MbRLuPMFBkeaAN61y2dVN4fYC5CaCsfLrWCAO9LNZdAblfslWNQ?=
 =?us-ascii?Q?sqMiii+PDSbJlCTGscBZQIdspKZ7XbAdf6vEDr5OsFhnwFO7q6vG3SfaKwFv?=
 =?us-ascii?Q?3boUo5vKWd+bPpwl8ORI5m7USPooHn1+QkqGj7wuMh+O3Fee5AOnbSmJQPJ1?=
 =?us-ascii?Q?TpbwxAjguS8QN/p35+0Q0Hz0unUp2akU/M+3kxncwcxjMrdYD11F7pigr58Q?=
 =?us-ascii?Q?NqW5Kpk6aLK34AvswdQOnd9q2lZUqsLEhY4TRXIsrDks+oAeLDQ0c/5hc9oY?=
 =?us-ascii?Q?jmD0/JiEFEsGiRsURSsn0FILZkGP7KjIzGGbX34tRkrhe0wnyiqJ6nmrlPn2?=
 =?us-ascii?Q?Mr0hHe3aeAcZ0/3Pp7/xdHKD+ztVkzC2mcmHpR9EWwsJV5+i79dtIOqBhGSf?=
 =?us-ascii?Q?jb9oiflhmZVFCVRemMJujjG9m4XWqXoTk8lyzcmURx7p0e6AAvOYzOa75Gnl?=
 =?us-ascii?Q?b5MlHZn8U2yoO5Ot4ti7/QHR7PDMZh8JVlW2zlG04QJ/3zgSul8cbln5Tkcn?=
 =?us-ascii?Q?7eeLAcJuD3o1ux/0FV19WEsp+KUE+T+gN0/cV1w2+Nz21FGtJKBfkq1J9XO9?=
 =?us-ascii?Q?CJBr7kKqlDnplKx8ooV6facj1P3LJ2qT/AcJXto3g8w12+QNsPpndQ/pYnOB?=
 =?us-ascii?Q?BtvnShF9PTbsxy0rUtXN35M0mZloaktPxCXce3jeMQnYEo1ampHwTvUZRmtW?=
 =?us-ascii?Q?lDkUAen9Q0Vkmn6XX23BNMNvKUaFuzkc9N5PjNlovjaWgs2Wy4nOhroqUf7Q?=
 =?us-ascii?Q?qOTiRvuP7pSJzV3QMJ65lTXVyvzTA3N6FrOW7odxac5nNetC+94yXINrZZVE?=
 =?us-ascii?Q?nRzp5aZ50J4k813TyFGNfhHeh4Z5T1/sJy7NzOQyXGvo05oh4bd+GPaVrLZ3?=
 =?us-ascii?Q?ZVLIfmg0z/Va3XUASkIzq/hPnwW2AOht146nfHehc7ZfPQ9+8bTg0TmJII05?=
 =?us-ascii?Q?IyFQtF0gV8Hw7quiiD497DeioPXTl3bpe3cpLLgvTpCSh1WpQVZgncEckkX/?=
 =?us-ascii?Q?Dudlc92TSK2kbb0k+tKDadU5wmhC4/r8u8zm5ZFIwoggZOTW2eatQfUxPGKd?=
 =?us-ascii?Q?baQU1cFbOhdx3H5Yqiv9zVbvpk5ROe1HDxfO/8tUU5u9u9wU5AsOmBXCZ9RT?=
 =?us-ascii?Q?Yi/+GtXZ2qW4wWZ9GGOabORa8S20L7WwyEOYj+7x9i31xx8QbTtB7MuNSgqR?=
 =?us-ascii?Q?uybqLqVMJh5kTePix2LO1KSSzrVIKAmZ+KBfrGaxvk2ogEM4T9JHtxrXbZHA?=
 =?us-ascii?Q?uXt9mLQBkxsVOmY3us6L9pJCx6axm159qeqKesSggZ+Upj+ihXpNWIUwRwxe?=
 =?us-ascii?Q?ouxdRnXspRCGn7hsLLRAEkAHBIE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b54e8db6-4b62-42bd-3faa-08d9b498eed0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 07:05:18.6038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rjx3zedo6rtyO6DjKjIC3JTxokgh1H3kxMAsAefF07nskxSH95W0bfemjPUGu4pqAffO2Z/GQjsmTSQVpRdn4Z+deide18JrwMTglcha3/A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4641
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10184 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112010040
X-Proofpoint-ORIG-GUID: qv41j19w2nbHc2mmjSAqzXYgtfeNgQ2e
X-Proofpoint-GUID: qv41j19w2nbHc2mmjSAqzXYgtfeNgQ2e
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I just sent an reply to the v1 patch with more explanations.

On Wed, Dec 01, 2021 at 02:29:08PM +0800, Yang Yingliang wrote:
> diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
> index 64d9feee1f39..105c58e749d6 100644
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -121,11 +121,12 @@ struct net_device *alloc_rtllib(int sizeof_priv)
>  	ieee->hwsec_active = 0;
>  
>  	memset(ieee->swcamtable, 0, sizeof(struct sw_cam_table) * 32);
> -	rtllib_softmac_init(ieee);
> +	if (rtllib_softmac_init(ieee))
> +		goto failed;

Please write this like so:

	err = rtllib_softmac_init(ieee);
	if (err)
		goto failed;

Otherwise it suggests that rtllib_softmac_init() returns boolean or
something.  I suggest changing rtllib_softmac_init() in a separate
patch 2/2.

> @@ -2962,8 +2962,10 @@ void rtllib_softmac_init(struct rtllib_device *ieee)
>  	for (i = 0; i < 5; i++)
>  		ieee->seq_ctrl[i] = 0;
>  	ieee->dot11d_info = kzalloc(sizeof(struct rt_dot11d_info), GFP_ATOMIC);
> -	if (!ieee->dot11d_info)
> +	if (!ieee->dot11d_info) {
>  		netdev_err(ieee->dev, "Can't alloc memory for DOT11D\n");

This error message should be deleted.  The kzalloc() function already
has a more useful message.

> +		return -ENOMEM;
> +	}
>  	ieee->LinkDetectInfo.SlotIndex = 0;
>  	ieee->LinkDetectInfo.SlotNum = 2;
>  	ieee->LinkDetectInfo.NumRecvBcnInPeriod = 0;

regards,
dan carpenter