Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D08C433EF for ; Wed, 1 Dec 2021 07:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347555AbhLAHhG (ORCPT ); Wed, 1 Dec 2021 02:37:06 -0500 Received: from mga12.intel.com ([192.55.52.136]:43907 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347829AbhLAHg6 (ORCPT ); Wed, 1 Dec 2021 02:36:58 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10184"; a="216421318" X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="216421318" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 23:33:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="512579936" Received: from mylly.fi.intel.com (HELO [10.237.72.148]) ([10.237.72.148]) by orsmga008.jf.intel.com with ESMTP; 30 Nov 2021 23:33:35 -0800 Subject: Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode To: "D, Lakshmi Sowjanya" , Wolfram Sang , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Senthil, Bala" , "N, Pandith" , Andy Shevchenko Cc: "Saha, Tamal" References: <20211109103552.18677-1-lakshmi.sowjanya.d@intel.com> <042d2c9f-4333-44b1-09c0-b0953a51c176@linux.intel.com> From: Jarkko Nikula Message-ID: <4a420cc0-d18a-32db-ed58-f611336c99ec@linux.intel.com> Date: Wed, 1 Dec 2021 09:33:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/21 7:51 AM, D, Lakshmi Sowjanya wrote: >> True, only sda_hold(_time) is u32 and other timing parameters are u16. >> >> Lakshmi: Would you like to send a patch fixing this and get more contributions >> to the driver :-) > > Thanks Wolfram and Jarkko, > > Sure. I will send a patch fixing it. > See the comments from Andy. Recent enough Elkhart Lake BIOS and his patches from last year already provide the timing parameters. Feeling embarrassed I forgot them :-( Jarkko