Date:   Wed, 1 Dec 2021 11:41:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Zhou Qingyang <zhou1615@umn.edu>
Cc:     kjlu@umn.edu, Neil Armstrong <narmstrong@baylibre.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Maxime Jourdan <mjourdan@baylibre.com>,
        linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: meson: vdec: Fix a NULL pointer dereference in
 amvdec_add_ts()
Message-ID: <20211201084108.GE9522@kadam>
References: <20211130161224.181519-1-zhou1615@umn.edu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211130161224.181519-1-zhou1615@umn.edu>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YMrQWK+09nMmeKc21q7FcaJLS6ACvLQSjeRcRRmtpPOzogpSeYZee8joTfls?=
 =?us-ascii?Q?hHU2WqgpaL5i+c1jfL1rqUbwJZ1wo8JFwlranj/0PU6LBdPXMDJbyyFVX1wN?=
 =?us-ascii?Q?NpwGuojnXjKWfVNTcUU5SXpikmqudjY7taDyNhfMdLEd5X50ZUsl+ungzjrq?=
 =?us-ascii?Q?oNH7Z8i5oFvLBrOmD1WZaRWPzdo2vkcs8RY74LSxdYjF8jemGxeWXdIvkGig?=
 =?us-ascii?Q?9o0ybGa3QNmAemitCHwQgA6OAiQ4HEAakiJAlBQVtJRwBy/0ea9GLx7BAql1?=
 =?us-ascii?Q?RA0zsEa6Svb4lxVC2voAYHr/arLb0pvM3nA5y8Q0yUPjaAC5eOjkw8Bl5rVk?=
 =?us-ascii?Q?DXXwy4siLrUmIUxWzlkOYnJAy7ehtzSBorSRB4vSKpjF5W9kpi0R3KQgg3Tt?=
 =?us-ascii?Q?DOV7ctAeNcic1bxszi2vYZFHpar5ku8nCXIYY6kLxQGw/Tl79+YdtG6fJZQh?=
 =?us-ascii?Q?Jue0ZtKPmroaEPTN3UW2okt95c/Tz+2EyTLWTn4EsGS2notenMKnwlrDc4V2?=
 =?us-ascii?Q?o+xtVXemmC6JdiP6eLwkjGEN7Z2Y/dyhLSBBhU3plHhGBqELWDtEZIedXHTt?=
 =?us-ascii?Q?Z9s9N4BqINYgLb2BOpYUzz6jSwb+XsiaCPw96zFn/Shfp6KCk5+dnBHkDrLn?=
 =?us-ascii?Q?m3D7COukxXvj8ouCAFX7ZE6wU1zH6TGNagvsfpkY3dU1leB3LB4pFt8gAfRH?=
 =?us-ascii?Q?4NtATm6kP4sEm6pmRJgFaaCeZDMpzdDH0h2PLzZfN2ZXGyPSgh1nlCTZYYpL?=
 =?us-ascii?Q?iDGLKtVcpfCMVuXeW5yVUTfPj+4KRdFZbFgbq4abQepCKPKl42Ralg6XG2rN?=
 =?us-ascii?Q?4Vkukm8VPO0vTahPDi5uYqbHg6LeqRvsMiwiMIUn8b6Cr+tSywv6FeCBYVsQ?=
 =?us-ascii?Q?Fv3q+i3nJsgSkX+U+Xaa7p+IMxoECc+oqbj+N4jndb0fTS2pT4AEoitLnmNa?=
 =?us-ascii?Q?Ay90xnik0ovKugCkrV475ceCi+CpI7eJMjYkQJd4jrlKcfiPSqGnRDDCUSFp?=
 =?us-ascii?Q?K6wZYc4MQgteDCt9tbcUuIe2thLbdDc1hCTbWBNF4EsSoOkA2Os55LAMOYNN?=
 =?us-ascii?Q?Y4S92WXuGm31DKxGgBcxbGJqVEY4jOfY3k29BCpm0pXvJ+lPoGbqLxs09RNy?=
 =?us-ascii?Q?PxH2jAaH38PoyvYX4iriaWaaRDRch9kqUI6dFA3h01IG599TWOt+n5XC+wAg?=
 =?us-ascii?Q?ohe/zBN6P/+/RKHw11lUkk0Wk3bsaCiyhY2bxQG32Rkymoo65QPb3ridraUW?=
 =?us-ascii?Q?IIR8uN0TIdURJiXwSredCILfXJfUZnJoCJGJZwtNcIfHwHAiiJTwv5OXGJA5?=
 =?us-ascii?Q?Z7NjfAW2PRRcOWd6cRnQeDL3dN3JqgcQ0wA1JHbujt3glJk8iUGE4vaxcgwx?=
 =?us-ascii?Q?sWf9gEObDEBKNQl32rILIdYYitW2jUc8iCv6/ycnADuLJrESSwsuD1oCUGBy?=
 =?us-ascii?Q?SfSB/qJwLptkvvctgi7+Uox8MGc+GYX/i4h90mpI0URjNxPoStwVxZbK5mK8?=
 =?us-ascii?Q?jp12jVDEKIvkba7i3KZbqbjEpjxwFbBJ4UxfYAGtxs3kWBAKNIzc3KpJhyMe?=
 =?us-ascii?Q?+dQrXRVPE7J9rGe8vBtYk8TRoLykXYQIMw7RgOxf0lZ+wiu5md1JovW/uZex?=
 =?us-ascii?Q?4TqkRsGCJEEo1x1oAlz76O8FchXo8l6L3ZcjGbzqKb0ZhPCjksbujwjFW3Fb?=
 =?us-ascii?Q?nNHAr/EWGeJrtTcOY1m6kwKtuk8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22a5b55b-e973-4c92-81e2-08d9b4a65fb3
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:41:31.9112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wSWFARdkXbNEE/8T362tI1b4dYD48xCB5YNDGeysh9KZfA8Iwme97u5wzST0oHgnRQZFvYjZ7SnlMUzowIlM8DXWV6ZqGCVGH+gVu8sz0l8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2399
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10184 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112010048
X-Proofpoint-GUID: TzUAeut8QQsDpBcUi0k1owdIAZv06PIS
X-Proofpoint-ORIG-GUID: TzUAeut8QQsDpBcUi0k1owdIAZv06PIS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 01, 2021 at 12:12:23AM +0800, Zhou Qingyang wrote:
> diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.c b/drivers/staging/media/meson/vdec/vdec_helpers.c
> index b9125c295d1d..41297c2f8f9a 100644
> --- a/drivers/staging/media/meson/vdec/vdec_helpers.c
> +++ b/drivers/staging/media/meson/vdec/vdec_helpers.c
> @@ -234,6 +234,11 @@ void amvdec_add_ts(struct amvdec_session *sess, u64 ts,
>  	unsigned long flags;
>  
>  	new_ts = kzalloc(sizeof(*new_ts), GFP_KERNEL);
> +	if (!new_ts) {
> +		dev_err(sess->core->dev_dec,
> +			"No enough memory in %s\n", __func__);
> +		return;

Please run checkpatch.pl on your patches.  The dev_err() message should
be deleted because kzalloc() already has a better message built in.

WARNING: Possible unnecessary 'out of memory' message
#50: FILE: drivers/staging/media/meson/vdec/vdec_helpers.c:238:
+       if (!new_ts) {
+               dev_err(sess->core->dev_dec,

regards,
dan carpenter