Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A33C433EF for ; Wed, 1 Dec 2021 09:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348111AbhLAJDd (ORCPT ); Wed, 1 Dec 2021 04:03:33 -0500 Received: from mga03.intel.com ([134.134.136.65]:62925 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242056AbhLAJDW (ORCPT ); Wed, 1 Dec 2021 04:03:22 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10184"; a="236361932" X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="236361932" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 01:00:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="654693452" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.199]) ([10.237.72.199]) by fmsmga001.fm.intel.com with ESMTP; 01 Dec 2021 00:59:58 -0800 Subject: Re: [PATCH] xhci: Remove CONFIG_USB_DEFAULT_PERSIST to prevent xHCI from runtime suspending To: Kai-Heng Feng , mathias.nyman@intel.com Cc: Greg Kroah-Hartman , "open list:USB XHCI DRIVER" , open list References: <20211119092628.677935-1-kai.heng.feng@canonical.com> From: Mathias Nyman Message-ID: Date: Wed, 1 Dec 2021 11:01:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1.12.2021 2.19, Kai-Heng Feng wrote: > On Fri, Nov 19, 2021 at 5:27 PM Kai-Heng Feng > wrote: >> >> When the xHCI is quirked with XHCI_RESET_ON_RESUME, runtime resume >> routine also resets the controller. >> >> This is bad for USB drivers without reset_resume callback, because >> there's no subsequent call of usb_dev_complete() -> >> usb_resume_complete() to force rebinding the driver to the device. For >> instance, btusb device stops working after xHCI controller is runtime >> resumed, if the controlled is quirked with XHCI_RESET_ON_RESUME. >> >> So always take XHCI_RESET_ON_RESUME into account to solve the issue. >> >> Signed-off-by: Kai-Heng Feng > > A gentle ping... Thanks Adding to queue -Mathias