Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751016AbXAQW4V (ORCPT ); Wed, 17 Jan 2007 17:56:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751411AbXAQW4U (ORCPT ); Wed, 17 Jan 2007 17:56:20 -0500 Received: from mail.screens.ru ([213.234.233.54]:59516 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbXAQW4T (ORCPT ); Wed, 17 Jan 2007 17:56:19 -0500 Date: Thu, 18 Jan 2007 01:55:24 +0300 From: Oleg Nesterov To: "Eric W. Biederman" Cc: Cedric Le Goater , Daniel Hokka Zakrisson , linux-kernel@vger.kernel.org, herbert@13thfloor.at, akpm@osdl.org, trond.myklebust@fys.uio.no, Linux Containers Subject: Re: NFS causing oops when freeing namespace Message-ID: <20070117225524.GA1572@tv-sign.ru> References: <57238.192.168.101.6.1169029688.squirrel@intranet> <51072.192.168.101.6.1169039633.squirrel@intranet> <20070117185823.GA878@tv-sign.ru> <45AE7705.4040603@fr.ibm.com> <20070117194632.GA1071@tv-sign.ru> <45AE87BC.4030404@fr.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 26 On 01/17, Eric W. Biederman wrote: > > Cedric Le Goater writes: > > > > your first analysis was correct : exit_task_namespaces() should be moved > > above exit_notify(tsk). It will require some extra fixes for nsproxy > > though. > > I think the only issue is the child_reaper and currently we only have one of > those. When we really do the pid namespace we are going to have to revisit > this. My gut feel says that we won't be able to exit our pid namespace until > the process is waited on. So we may need to break up exit_task_namespace into > individual components. I agree, but please note that the child_reaper is not the only issue. Think about sub-thread which auto-reaps itself. I'd suggest to add the comment in do_exit() after exit_notify() to remind that the task is really dead now, it has no ->signal, it can't be seen in /proc/, we can't send a signal to it, etc. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/