Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6812C433FE for ; Wed, 1 Dec 2021 12:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349199AbhLAMM0 (ORCPT ); Wed, 1 Dec 2021 07:12:26 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:35614 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242864AbhLAMMW (ORCPT ); Wed, 1 Dec 2021 07:12:22 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 20F951F458EB DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638360540; bh=e6GNEu+wR3rqkC7g+n4jt6R8FC/jvcD5LlLpfyUKevg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VqJz1bIHMb5HoP/P4opc9HPfG7iK1rCTWApS2B5acoRWT9mCRCnuain9t0YnHzexF qHJ88mE/PiqXBmKXm8hg33riacLDMzs/mMWiRGGv2sykNbRqgM9gKVwfrcbZM/zjM4 136OPMrVKAuwcAuPwHQOhhZibY9RPLJcJBXFJKg7ERYxEENSwqABTZfhZ7osoRqTPF TWLslssNBDT1VxQ4EgB4ZsBfy82/WYlSGSP0moa7h0TPoanLREVUtUU4ZaWoyORsgx BChCZ3DN3kCERAiucn2aPhflUQbasMzW4Q8HHtqI2umDDv1cCfjCRlPwycaWsVSHcO G8URgRKgQUGng== Subject: Re: [PATCH v11, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-19-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <540a5ac7-80a2-a72c-87fe-5042f21f8deb@collabora.com> Date: Wed, 1 Dec 2021 13:08:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-19-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 29/11/21 04:42, Yunfei Dong ha scritto: > There are only two lines in mtk_vcodec_release_dec_pm, using > pm_runtime_disable and put_device instead directly. > > Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with > pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since > it only has clock operations now. > > Signed-off-by: Yunfei Dong > Co-developed-by: Yong Wu > --- > .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 10 +++++++--- > .../media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 7 +++++-- > .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 12 ++---------- > .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 3 +-- > 4 files changed, 15 insertions(+), 17 deletions(-) > Reviewed-by: AngeloGioacchino Del Regno