Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D41C433F5 for ; Wed, 1 Dec 2021 12:09:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349232AbhLAMMi (ORCPT ); Wed, 1 Dec 2021 07:12:38 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:35636 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349173AbhLAMMX (ORCPT ); Wed, 1 Dec 2021 07:12:23 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 42FF61F458EC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638360541; bh=Pph0h28u90fWIpAEnT37cWqdNQe0Gk7uaTOWOIg4P9Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Vp1a4AnNC/hCYZImxafQPXGE6lBaxAJp+NpFtPmFYARGG2tdk+b0/U3v/ustS4H9i FOI0ql6mGk9KG0SaguWGmT6UhxEwnGwSmL+2qwZIywym1GVTRPNz24PHdlOSoHySWu XsicMKGJWClwyRyX+Ja3p0V4w8pMICqADb/r1CZjrz+F/x4pshyu2+wWx2XYRrF09G 7Nf4XpjfXAvLfyiql6V/l9x0v1pAatAEAB4JqRfbQd43e4j7sJQH/yjOVeLixF+vSv gTGDoYq6xP8fjVjYw4geuQp2PQzBvMkVn7LvTmLJSkHme3Cf1NG2FTPqQ1z6gxCZp3 FG0bomir76f/g== Subject: Re: [PATCH v11, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-20-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <5d235ba6-213a-598f-e18f-93b51e535285@collabora.com> Date: Wed, 1 Dec 2021 13:08:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-20-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 29/11/21 04:42, Yunfei Dong ha scritto: > There are only two lines in mtk_vcodec_release_enc_pm, using > pm_runtime_disable and put_device instead directly. > > Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with > pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since > it only has clock operations now. > > Signed-off-by: Yunfei Dong > Co-developed-by: Yong Wu > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 9 ++++++--- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c | 9 +-------- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.h | 3 +-- > 3 files changed, 8 insertions(+), 13 deletions(-) > Reviewed-by: AngeloGioacchino Del Regno