Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbXARBLu (ORCPT ); Wed, 17 Jan 2007 20:11:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751867AbXARBLu (ORCPT ); Wed, 17 Jan 2007 20:11:50 -0500 Received: from omx1-ext.sgi.com ([192.48.179.11]:36582 "EHLO omx1.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751874AbXARBLt (ORCPT ); Wed, 17 Jan 2007 20:11:49 -0500 Date: Wed, 17 Jan 2007 17:10:25 -0800 (PST) From: Christoph Lameter To: Andrew Morton cc: menage@google.com, linux-kernel@vger.kernel.org, nickpiggin@yahoo.com.au, linux-mm@kvack.org, ak@suse.de, pj@sgi.com, dgc@sgi.com Subject: Re: [RFC 0/8] Cpuset aware writeback In-Reply-To: <20070117141046.cd19c9e8.akpm@osdl.org> Message-ID: References: <20070116054743.15358.77287.sendpatchset@schroedinger.engr.sgi.com> <20070116135325.3441f62b.akpm@osdl.org> <20070116154054.e655f75c.akpm@osdl.org> <20070116170734.947264f2.akpm@osdl.org> <20070116183406.ed777440.akpm@osdl.org> <20070116200506.d19eacf5.akpm@osdl.org> <20070116230034.b8cb4263.akpm@osdl.org> <20070117141046.cd19c9e8.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 20 On Wed, 17 Jan 2007, Andrew Morton wrote: > > The inode lock is not taken when the page is dirtied. > > The inode_lock is taken when the address_space's first page is dirtied. It is > also taken when the address_space's last dirty page is cleaned. So the place > where the inode is added to and removed from sb->s_dirty is, I think, exactly > the place where we want to attach and detach address_space.dirty_page_nodemask. The problem there is that we do a GFP_ATOMIC allocation (no allocation context) that may fail when the first page is dirtied. We must therefore be able to subsequently allocate the nodemask_t in set_page_dirty(). Otherwise the first failure will mean that there will never be a dirty map for the inode/mapping. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/