Date:   Wed, 1 Dec 2021 15:54:24 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     William Kucharski <william.kucharski@oracle.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: Trace event cgroup id fields should be u64
Message-ID: <YaeMoCGy2MXQtJ/U@kroah.com>
References: <20211201144043.557470-1-william.kucharski@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211201144043.557470-1-william.kucharski@oracle.com>
Precedence: bulk

On Wed, Dec 01, 2021 at 07:40:43AM -0700, William Kucharski wrote:
> Various trace event fields that store cgroup IDs were declared
> as ints, but cgroup_id(() returns a u64 and the conversion was
> not intended.
> 
> Also remove extraneous spaces in fields that are no longer proper C style.

Shouldn't this be 2 different patches?  When writing "also" that's a
huge hint that the patch should be split up.

So one for the bugfix, and one for the coding style change?

thanks,

greg k-h