Date:   Wed, 1 Dec 2021 11:11:21 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Logan Gunthorpe <logang@deltatee.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Megha Dey <megha.dey@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jon Mason <jdmason@kudzu.us>,
        Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <allenbh@gmail.com>, linux-ntb@googlegroups.com,
        linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>, x86@kernel.org
Subject: Re: [patch 21/32] NTB/msi: Convert to msi_on_each_desc()
Message-ID: <20211201151121.GL4670@nvidia.com>
References: <20211126232735.547996838@linutronix.de>
 <7daba0e2-73a3-4980-c3a5-a71f6b597b22@deltatee.com>
 <874k7ueldt.ffs@tglx>
 <6ba084d6-2b26-7c86-4526-8fcd3d921dfd@deltatee.com>
 <87ilwacwp8.ffs@tglx>
 <d6f13729-1b83-fa7d-3f0d-98d4e3f7a2aa@deltatee.com>
 <87v909bf2k.ffs@tglx>
 <20211130202800.GE4670@nvidia.com>
 <87o861banv.ffs@tglx>
 <871r2w9y3x.ffs@tglx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871r2w9y3x.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rGvBQIsKaOrHJUYPTpU6jM37VH/jkkBIlOgASu8XZwZxgMe/zgUJ59HBEFCl?=
 =?us-ascii?Q?oLDqc9G7s1MqrIWGHKu2U58iQIr+Mrh9+Pmipz7KrqCBFWIuUXIjsAtCBuwp?=
 =?us-ascii?Q?9LDosbWndlcB13kzqglSv7LJ08FKm1aa86lyuXkKHCRIeoBCwswqnzLoC5nM?=
 =?us-ascii?Q?g/rdLDC9KL15D3z73yN4E6zsJQbyrod3zPnsZxn+zodBIklAZ2ZU/JtxdB50?=
 =?us-ascii?Q?T74qgJRDMd4c0tjiVbK7jwtRoWnZn+qcItzkizwXZ148QYCBLYlZ+TxwywF3?=
 =?us-ascii?Q?iqdTWN/RO8vOIsyMWVPLShFX4fwbaEjDQWJdwZgSHNaIPitUBXAXZCZ/xJrx?=
 =?us-ascii?Q?H/iGxg+yOxh2xIAQmS7lAPeh/Y5nN2VR2tbi0G+NMlhvRsSKRNa9XgiYjT+Y?=
 =?us-ascii?Q?M//BZR4t3eXxTCA+EQOZq7WS768zCam5n7v/wG5ZN/WhMy+232LPSkEtxe9A?=
 =?us-ascii?Q?Z8hjAdSDTfZhhGGt69LNPmIzCGufV4lsAmhzuSXk8Khq2X5ZCqu60yxxhuOZ?=
 =?us-ascii?Q?u1rkK1Ol6vVjNIbSJkS7AqhWimFdVEwurPqMJ197KLLtTRO5ELsBQBYLTuUi?=
 =?us-ascii?Q?yg+6xPUl7+I1U3fGg5OtuNvyj6Jdjb8ZnvaGlife7JxUy/K/mtrV8mCNnqJv?=
 =?us-ascii?Q?hb9OKWRnRPar5qPPaH2ZZw8BWRjJQCPYvOnZjQcpZXYwTgj4tzNQuTQ/GsOS?=
 =?us-ascii?Q?SYlpy/6mzh7+CautHsBGFanye3grzlvJAr0uNGjcwxFmrYsk0fK3lSXihcky?=
 =?us-ascii?Q?GH58LQ0QrrAlB5Toq72JQBfHBGbuSL9UkjLF2904RlxYX5zzh2bMhe0z4m35?=
 =?us-ascii?Q?FH4++WKFAFw+mWYnccDQYvj0eDwNIwIP0NdhlTJYwdS1pRCCpgB8Utn+km9I?=
 =?us-ascii?Q?o3n5Msm8iHjboemGa1lLM7y+Kmwm3ayTNdSX54zNYZ/8c+/Rr6fbQq3UvnYz?=
 =?us-ascii?Q?nox9ujgzIIn4x1037NX2YFUD1KaL9lNZweh2tDaMSDzo8SDrOJhMxeSe91Qg?=
 =?us-ascii?Q?sK+6PDFhvE2b+wuUK2tyReH5xHPrAcouzK55V0MXxc7wPhe7ODNg2jfQvU1/?=
 =?us-ascii?Q?LM4ahv9gOaGGAO70yQUCPHd8OmKbAvxPZOK38kaAs9JscckkCySan7xfW/UU?=
 =?us-ascii?Q?4MicPldzzWrQYryhJh9naenZB5oPhcmYZgbvHWO5y4/0o6h1//dVOWLK5o+J?=
 =?us-ascii?Q?z69GvKmDUXeMsI9GgobtBluh9gYc2+3E4SOTy5jCAId/7zNuQohuJ0h3mYTR?=
 =?us-ascii?Q?ob0OvQ/Yk9s5D10+ZUPpOhBonC1Ik0TGZwcVR+XCXZ0iP0rFHuWpd80Z93nv?=
 =?us-ascii?Q?xJCBcPx7BS821xqBHfmgno5I1WcCIgVMyvIuBPTkShfmRONAcgYQmHLrogvB?=
 =?us-ascii?Q?ZYXb9f2UATbVZ03Ya1Gn8FLwm9tkLgiPF76UB3rKR7Qk64sA66CIpk6ocoem?=
 =?us-ascii?Q?cOyTo4w8KL/QMttM67DpclN4fasu2QXOuUvjZcgLPkABcDWLdOt+6evMq12u?=
 =?us-ascii?Q?OxEZcDotIs2rBz0KVKuh8SAZb/DTYCqwPzp9YwyKQLGugZOMcAFS5P6nwIoG?=
 =?us-ascii?Q?CrSc5BXOKjSVQMY03MA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b67d7299-5fec-410d-0478-08d9b4dcd606
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB5520.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 15:11:22.7831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P7HF3Sla2SFXdMrITnR7n4zZDiTM2UYBcqUzTnGnaCG+haZFh6nDXRTTEtHWqy7C
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5280
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 01, 2021 at 03:52:02PM +0100, Thomas Gleixner wrote:
> So we really can go and create a MSI irqdomain and stick the pointer
> into stdev->dev.irqdomain. The parent domain of this irqdomain is
> 
>      stdev->pdev.dev.irqdomain->parent

It can work (pending some solution to the iommu stuff), but IMHO it is
strange/hacky to put HW objects like irqdomain on what is a character
struct device with a set major/minor in dev->devt and associated
struct cdev.

Conceptually it makes no sense to me, cdevs are software constructs,
they should never go into HW areas..

Jason