From:   William Kucharski <william.kucharski@oracle.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: Trace event cgroup id fields should be u64
Thread-Topic: [PATCH] cgroup: Trace event cgroup id fields should be u64
Thread-Index: AQHX5sFwaB6Hoy4YakmqLMRZzO8P2KwduSUAgAAGQwA=
Date:   Wed, 1 Dec 2021 15:16:49 +0000
Message-ID: <E346515B-DEE8-4CE8-BCBA-3B11EEFA838C@oracle.com>
References: <20211201144043.557470-1-william.kucharski@oracle.com>
 <YaeMoCGy2MXQtJ/U@kroah.com>
In-Reply-To: <YaeMoCGy2MXQtJ/U@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8XgMM8idahVJbGIsWRYXZcxfimqiQGiGXGdZj7RRHrmmn+4wgCn+qYoDx1E4?=
 =?us-ascii?Q?MlHJlcVlJ6pif6J8Xo+UKHOYWm6d9BbLKxFEkHS6pEjzpD4zRvVynotF/i5x?=
 =?us-ascii?Q?6vUwiFBqhW7Hi2MCGhNxvqhbNUAe3hfap+FBaehSIoOtL9ypBFWxPqarFwIr?=
 =?us-ascii?Q?JulqQFcsT889libzNtoPjfK8qBiZ02qBfx3/fQy4zy1TvBrTd6HrdeQXRL04?=
 =?us-ascii?Q?4yabE7fOpZGT0UeYu9LHpxDjSA2FgnpS15Lh4bxmjORqFafdPggkkF7rlyMW?=
 =?us-ascii?Q?JneqQ/ljx+UTYYdeAWfFLWhYcZurvZhznRmUWnzDQPXGLE7cvTQLzn9DPX2W?=
 =?us-ascii?Q?m+kgxnDJsWrWWuWBjbeG5NJv6jEHPz2AGy9/vO5SXRkXakjobGPIVQ3N+cFQ?=
 =?us-ascii?Q?SFubmEnp8ElEA/yQkomjaP860YnZijQ46oRJFdhZizgeulGjl5QMs9RRvbxq?=
 =?us-ascii?Q?6+bGHG2xgFODz9musSeHd8zPlIpIJogMMQuYFH5ac7FZFQHDmZXfHMDSyYbR?=
 =?us-ascii?Q?45liFmpm3WYQrHd3zqS2iFRAoAUDVhJe5CUtCVZetu4prU6PwidYhv9gWe98?=
 =?us-ascii?Q?ELe/P78k4YCHhiharzmNXSNm8pI1hzxYy+fYDZDL6oOnZgrcLog4c6GymRgS?=
 =?us-ascii?Q?SaTZgaRfEbNQUpQJs0qozKQ41FqOt7aYiXc5UH5ygiKSdbilQppvfot+yCeT?=
 =?us-ascii?Q?YO5f6wYVjgHZ+8oz2bsz7738QDhR6t/lqSsKu0SQwH+DudI31fgxwkzb8gHM?=
 =?us-ascii?Q?4PSxsjvmRqZBR1yjl7NCHbeuC97FSj54+Kp75v/Kde9GUa0vj6MGOgzTG6ab?=
 =?us-ascii?Q?MWs/Nx6MVi6k9w/LwqnWS3F5Sf2Viei98ZRD76Xu2pAfXJzSdo7eICmNQwP/?=
 =?us-ascii?Q?rkqvU/QWlx8Q+HBrpXggh6Vfyp5ZoY+B4yspWAOTCJmdnVLDFhUipvtVWmgD?=
 =?us-ascii?Q?4q8v9dYh08f2LOipuJqbuevVhAzeQkMLMQL41bSTxF130rqwaiPbSBqeQ7Yb?=
 =?us-ascii?Q?5W3V8afm7SbWoZENP3ZYAaaFKsmCOil4+4fLWH2V2ZqMhdInBZ14roUcz/tW?=
 =?us-ascii?Q?F0DwHEo4vSipyU4bI5O4mpLE8ue3UTLCxeAlicWMA8cTVab7dAoRXeezPvsc?=
 =?us-ascii?Q?9JbymbPiroVlhK/AzxaZFJMGSsFvNUiT931CtyS2VJZVJZQ4VMiQk59Px7FL?=
 =?us-ascii?Q?OsKBmTZFBSSFg5jpBotaP8Ig/5qulC3/o46jfGmqo8sLq8W5D6Symw99kOcz?=
 =?us-ascii?Q?O635OgdZP5PdaJbQYgSrWIyv2TPgrOO9EfNjsyG/CqL1HoTXZxNVT5LlQ2pm?=
 =?us-ascii?Q?H+lsfVeU+9TJYogBlP+9jRZW55jsAMUabvNu4E+oa1zVtDvzq+Vxx2OLEG89?=
 =?us-ascii?Q?fGDUs5dcJk5xqMQieJyo0mrKdTIrH8TsqkHAkR2VPlhn3uA5cGZFMCFh76Hi?=
 =?us-ascii?Q?92TARw2jITbpPFbK3dXeUuNF0MxA0uH9KS/ftMEOO6OUODLft0vh8YkKInuA?=
 =?us-ascii?Q?oM0F35a8ujWRebEXmWDq8YnheukBxff9iT6WfwwpdQJU3uW/3ql8ftfyOTTU?=
 =?us-ascii?Q?9+E6UE/NfTfSsMnWoSTe/6eNVcN8e9r7fYlDYeGtDiqxy1Egqp3SU4ZcHSj3?=
 =?us-ascii?Q?rFwFiyHsGPYKKOmoxgEZG2OTcE6BX3+jdYOSKyxAmE1Z7O4/rDq8/Hjs8ijv?=
 =?us-ascii?Q?35xzEeE82K8Ax01F/mor7P1H4J0z9Go+4jirSnQtpW3y/pQOf624uMqmy6p8?=
 =?us-ascii?Q?sp4l7NQjltt+aJ0bXda3PdGO2KjUvIc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F1C72385D0A2B34293495A0AE7866ADC@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR10MB5559.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5dca60a-44d1-4fe1-901e-08d9b4dd98ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 15:16:49.4769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mF249EA184UXScyKKvGJ0STEP1R82AD4MIRamm5ll5+oLzu4AhyQcPIdaSPk2Q1gzb88kpnPmX6ImkLT00sMVyBlUTxq76qETcAkZzy6GLQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5844
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10184 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112010087
X-Proofpoint-ORIG-GUID: vE48uRGKyy0EeHzVMYO1G-864Mj5QKGa
X-Proofpoint-GUID: vE48uRGKyy0EeHzVMYO1G-864Mj5QKGa
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I'll break it up into two patches if you prefer, one that makes the stylist=
ic change and then
another that makes the u64 change.

> On Dec 1, 2021, at 7:54 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.or=
g> wrote:
>=20
> On Wed, Dec 01, 2021 at 07:40:43AM -0700, William Kucharski wrote:
>> Various trace event fields that store cgroup IDs were declared
>> as ints, but cgroup_id(() returns a u64 and the conversion was
>> not intended.
>>=20
>> Also remove extraneous spaces in fields that are no longer proper C styl=
e.
>=20
> Shouldn't this be 2 different patches?  When writing "also" that's a
> huge hint that the patch should be split up.
>=20
> So one for the bugfix, and one for the coding style change?
>=20
> thanks,
>=20
> greg k-h