Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbXAREVc (ORCPT ); Wed, 17 Jan 2007 23:21:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751923AbXAREVc (ORCPT ); Wed, 17 Jan 2007 23:21:32 -0500 Received: from 1wt.eu ([62.212.114.60]:1989 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919AbXAREVc (ORCPT ); Wed, 17 Jan 2007 23:21:32 -0500 Date: Thu, 18 Jan 2007 05:21:16 +0100 From: Willy Tarreau To: Grant Coady Cc: Santiago Garcia Mantinan , linux-kernel@vger.kernel.org, debian-kernel@lists.debian.org, dannf@dannf.org Subject: Re: problems with latest smbfs changes on 2.4.34 and security backports Message-ID: <20070118042116.GA11914@1wt.eu> References: <20070117100030.GA11251@clandestino.aytolacoruna.es> <20070117215519.GX24090@1wt.eu> <4pctq2tqjnoap3khma0496h2fhfpg1rs75@4ax.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4pctq2tqjnoap3khma0496h2fhfpg1rs75@4ax.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 37 Hi Grant ! On Thu, Jan 18, 2007 at 11:09:57AM +1100, Grant Coady wrote: (...) > > } else { > >- mnt->file_mode = mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP | > >- S_IROTH | S_IXOTH | S_IFREG; > >- mnt->dir_mode = mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP | > >- S_IROTH | S_IXOTH | S_IFDIR; > >+ mnt->file_mode = S_IRWXU | S_IRGRP | S_IXGRP | > >+ S_IROTH | S_IXOTH | S_IFREG | S_IFLNK; > >+ mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP | > >+ S_IROTH | S_IXOTH | S_IFDIR; > > if (parse_options(mnt, raw_data)) > > goto out_bad_option; > > I'm comparing 2.4.33.3 with 2.4.34, with 2.4.34 and above patch symlinks > to directories seen as target, nor can they be created (Operation not > permitted...) Thanks very much Grant for the test. Could you try a symlink to a file ? And while we're at it, would you like to try to add "|S_IFLNK" to mnt->dir_mode ? If my suggestion was stupid, at least let's test it to full extent ;-) I had another idea looking at the code but since I really don't know it, I would not like to propose random changes till this magically works. I'd wait for Dann who understood the code. Best regards, Willy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/