Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbXARIZx (ORCPT ); Thu, 18 Jan 2007 03:25:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751950AbXARIZx (ORCPT ); Thu, 18 Jan 2007 03:25:53 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:35344 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbXARIZw (ORCPT ); Thu, 18 Jan 2007 03:25:52 -0500 Subject: Re: [PATCH] Fix missing include of list.h in sysfs.h From: Frank Haverkamp Reply-To: haver@vnet.ibm.com To: Greg KH Cc: linux-kernel@vger.kernel.org, Frank Haverkamp In-Reply-To: <20070117211447.GA32495@kroah.com> References: <1169052679.21717.9.camel@localhost.localdomain> <20070117211447.GA32495@kroah.com> Content-Type: text/plain Organization: IBM Date: Thu, 18 Jan 2007 09:25:45 +0100 Message-Id: <1169108745.4231.6.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 20 Hi Greg, On Wed, 2007-01-17 at 13:14 -0800, Greg KH wrote: > Does this currently cause a build error on any platform for 2.6.20-rc5? Not that I know of. I saw it because a friend of mine tried to port some old code and played with the include ordering. Somehow he got a compile error doing it, and we found that it is strange that sysfs.h is using structs from list.h but is not including it. As result I sent the patch to propose that it gets included to avoid any possible trouble. Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/