MIME-Version: 1.0
References: <20211201074021.18097-1-tangyizhou@huawei.com> <20211201074021.18097-2-tangyizhou@huawei.com>
 <20211201071937.e6uso2qwzgtbfest@vireshk-i7>
In-Reply-To: <20211201071937.e6uso2qwzgtbfest@vireshk-i7>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 1 Dec 2021 20:04:04 +0100
Message-ID: <CAJZ5v0i4ursRcPs0FOyuY5iCZZySxoQhz=9Pnbcw+xXRPHjz3A@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] cpufreq: Fix a comment in cpufreq_policy_free
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        Tang Yizhou <tangyizhou@huawei.com>
Cc:     Rafael Wysocki <rafael.j.wysocki@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        zhengbin13@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 1, 2021 at 8:19 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 01-12-21, 15:40, Tang Yizhou wrote:
> > Make the comment of blocking_notifier_call_chain() easier to
> > understand.
> >
> > Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> > ---
> >  drivers/cpufreq/cpufreq.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index e338d2f010fe..db0b4b4258d5 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -1296,8 +1296,9 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy)
> >
> >       if (policy->max_freq_req) {
> >               /*
> > -              * CPUFREQ_CREATE_POLICY notification is sent only after
> > -              * successfully adding max_freq_req request.
> > +              * Remove max_freq_req after sending CPUFREQ_REMOVE_POLICY
> > +              * notification, since CPUFREQ_CREATE_POLICY notification was
> > +              * sent after adding max_freq_req earlier.
> >                */
> >               blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
> >                                            CPUFREQ_REMOVE_POLICY, policy);
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied as 5.16-rc material along with the [2/2[, thanks!