Sender: Corey Minyard <tcminyard@gmail.com>
Date:   Wed, 1 Dec 2021 13:42:17 -0600
From:   Corey Minyard <minyard@acm.org>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi/watchdog: Constify ident
Message-ID: <20211201194217.GI15676@minyard.net>
Reply-To: minyard@acm.org
References: <20211128220154.32927-1-rikard.falkeborn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211128220154.32927-1-rikard.falkeborn@gmail.com>
Precedence: bulk

On Sun, Nov 28, 2021 at 11:01:54PM +0100, Rikard Falkeborn wrote:
> ident is not modified and can be made const to allow the compiler to put
> it in read-only memory.

In my queue for next release.  Thanks.

-corey

> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  drivers/char/ipmi/ipmi_watchdog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 883b4a341012..0604abdd249a 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -668,7 +668,7 @@ static int ipmi_heartbeat(void)
>  	return rv;
>  }
>  
> -static struct watchdog_info ident = {
> +static const struct watchdog_info ident = {
>  	.options	= 0,	/* WDIOF_SETTIMEOUT, */
>  	.firmware_version = 1,
>  	.identity	= "IPMI"
> -- 
> 2.34.1
>