Subject: Re: [PATCH v1 0/4] Share common features between AMD SEV / TDX guest
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "H . Peter Anvin" <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20211116004528.2928887-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20211201163430.2ncgynzns5t6gvof@black.fi.intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <611026ac-0f15-0da4-aa97-e0412f1fcc78@amd.com>
Date:   Wed, 1 Dec 2021 13:57:43 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211201163430.2ncgynzns5t6gvof@black.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmhBMzIrTFdqR2huZUVoanpKdGlBRlVuaHR0V1c0UXM2c0h0OFA0RGgrSHJt?=
 =?utf-8?B?L3lJdUxVa1A1cjdUOFA5OFNsNVZDWDlmRWRpUVJBRFg1elc3Kzk1dzJJYURL?=
 =?utf-8?B?d3paRk9SSkY4TkV6T2JzYzBhMjBXQ0JVZHZiWVVFbTQxNW1td1Q2MHFOTTg5?=
 =?utf-8?B?YmI3bjdEYmV0eHVZWXU3ZExXejd6cWUvSmRiTTlWdEhkY3BWbit1Sy9WaUMr?=
 =?utf-8?B?QjFZS0ZFTHhDMy9pcE54VzM4ell6UkFGQWpodHcvQTRYblZibERTVHUzWGxF?=
 =?utf-8?B?SHlwcW9HNmJyM250UlU1UHVydkc3L09EeE95OFZ0OUxnaC92Yklvckxuelhr?=
 =?utf-8?B?U2RuL2k5U1JKT1FobGdRTVozVEdrYStSQUw4V3Y3YTFXVVIxek9Eai83SnpO?=
 =?utf-8?B?THJOZjBEWWhCSHBFMHdQQ3d2OUVpY09td1VCdkRTZ0lCZk9zVTFxZGdHbnhD?=
 =?utf-8?B?MHZiMWUzc2pjdUdINzlhWUYzZXlpWUdBUSsrR1JFVXRzbDIzRy8zaTV6Nkcy?=
 =?utf-8?B?N08wbXVXdERNVHBOVEkzNVVpODZSOWUvYlV2V1JKcm9INXh1K1JkS2dqRUFp?=
 =?utf-8?B?MUIrQnhqaHFzNlc2SEIyWVgrbXZJaWdaT28yTjBQc21Id3Rwd2ZmejRqbDNx?=
 =?utf-8?B?QXp0YzBuSXdxcWZHd3hsUXVUb0ttUjI4SGU0K2NqOGh2aU1QVHAvN0FQZHRt?=
 =?utf-8?B?VloxZlFscjQxVkZoSUtSRjQzczdNR1pLeVFtcngwNFdQV3ZVYzVISlZYUHJP?=
 =?utf-8?B?RzFXNXNVd2dlazlmbTdROU5ja3pGU0pyemxKSDZuOGJOaGlIM2ZnWFZwQjR0?=
 =?utf-8?B?d2tTSmk1NXhBSkEyaktBYkVGTm5NVDlQYk04OTM0Y1A5SW5UZ2IrQ2VpNDVx?=
 =?utf-8?B?ZU1UTUNMNnRRZFBFYVRWcFRoZHNVMVdlV1RRMGYrRVN4UHltZlN2V25aVjVQ?=
 =?utf-8?B?bVJFeStyYTIyNUdhWUtIOGZqQlNBNlhZNmlIUDdjSnNUVllyMlFmVFJWZXZi?=
 =?utf-8?B?dGduelkycUYvZjFUMXE2RTZmN2I0c0U5UGVUR1R0NlhHZVJid1JHaUVRRjJ5?=
 =?utf-8?B?ZzEvSWo1TXp1S3B3WTZLVjdmdTNtUDlNS0tWRlpYM01GUGJ3ZzBJcDlKUUcy?=
 =?utf-8?B?cmFjdWdZb2Y1Y3E4NmxDUXYyaTFOTjVGNEd2VU1GVGxrK1JWZ3FiWlNmeFJM?=
 =?utf-8?B?Z3FJYjdSUTZyTXVlbytoZUJhOGZsS3d6c2JGNnNuME1rdDBlbjYxOTVlUGRQ?=
 =?utf-8?B?M1hUZkdvUkZSTHdtTE9EcXErcDFsYS9rK1VibERPQTN4UG9HS2tqTVM1RU9T?=
 =?utf-8?B?N1ozY1BvZWxkZGt5M0N6TVMvMUt3dEQ1N1lhcVQyWWdxbnlUYjd2Z21Qb3g2?=
 =?utf-8?B?VHlOMDE3Y04zY1pBQlZmT3pXbWhVTGNKREhySXZodVNobEZLc3B0eEJjaHhY?=
 =?utf-8?B?SEpuQWhueGcvV1ovOHZHR21ZcjcyR2FSaFBPS0dlQ3pKZXlRd3llZzNramlP?=
 =?utf-8?B?Z21ZTURNS0FsRk13R01IUSs2VkRBUDVQdGtlcFU2UzRiT1dVaVU1Mk4vSUxp?=
 =?utf-8?B?eEpmMWtnSC9TNTIzVkpFODl3N3Q0TC9vSWl1UVI2bDFGek92Z3VNMFE4ZExo?=
 =?utf-8?B?ZERmWG10dXpHWFM5QURZcFB0S2ZvZ3pPUktHZmxFQnJIUk5YdUM1eTZIb1pN?=
 =?utf-8?B?dzNZcGdyUnA3b3JJQTUvQjR4dENXR05zZVhKNVNLWS9FUFhsSkd4WC9UVHpp?=
 =?utf-8?B?cUJIcVF5aHFGNVFiM0RTdGNKSW9mN3BkTmxYcVlsRnRBWUZpQnpXdHhnaVdJ?=
 =?utf-8?B?VzFTQ1l0bFB1ekJGYU92QVFKM2JVOFRHZHNCM3FWaFB5R3VhbU5iN2FEZW0y?=
 =?utf-8?B?YXVaL3VIQjVJNU8yUzg1WFFIQWJtMkNxR0hMcEZCdUhEVlo5TkNGS1JyM0ZO?=
 =?utf-8?B?Z1RWNXdJcVU3blRuMEUyWTh5UDVLNDZ3WEFyT2VSbkR6ZTBPZGl1VmlyUElm?=
 =?utf-8?B?QnloSEZqRWpMeGdOejVxVVpibUsyZ0ZGNCt3TDNQM3hSL1pjbGZYWlArOG9j?=
 =?utf-8?B?UmNtNjh1WFNkcVY3b0Frcm51RktGNGg1bzlLbjFrbDg3TkFCdXVHa2xQcEt0?=
 =?utf-8?B?bmc1MzdIRXVOc2FCUStwalpmZ1ZlQlFDdjZpQi9nQndNK1NldUYxYi9SVFZ4?=
 =?utf-8?Q?IbvjYv3ciSXgVOYQF+1J8k8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9c4444b-39ee-4249-886e-08d9b504d858
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 19:57:46.5246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x1dIybn7lHqNsnGcpApFU1FsRV2JGurFvAhpGtiMRvkhYk99AfCIFyHE+Z4dho77fLb1fRs9XBmFOIDz1Qq2Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5391
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/1/21 10:34 AM, Kirill A. Shutemov wrote:
> On Mon, Nov 15, 2021 at 04:45:24PM -0800, Kuppuswamy Sathyanarayanan wrote:
>> Hi All,
>>
>> Intel's Trust Domain Extensions (TDX) protect guest VMs from malicious
>> hosts and some physical attacks. TDX has a lot of similarities to AMD SEV.
>> Features like encryption/decryption and string I/O unroll support can
>> be shared between these two technologies.
>>
>> This patch set adds infrastructure changes required to share the code
>> between AMD SEV and TDX.
> 
> Tom, Joerg, could you folks look at this? Your Ack would be very helpful.

I had a couple of comments on the patches, but they did build and test 
successfully with both SEV and SEV-ES guests.

Thanks,
Tom

>