Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] PCI: mt7621: Kconfig: Convert driver into 'bool'
To:     Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        linux-pci@vger.kernel.org
Cc:     tsbogend@alpha.franken.de, lorenzo.pieralisi@arm.com,
        bhelgaas@google.com, arnd@arndb.de, linux-kernel@vger.kernel.org
References: <20211201213402.22802-1-sergio.paracuellos@gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <753baba9-ba09-a55c-d969-a498a695faa9@roeck-us.net>
Date:   Wed, 1 Dec 2021 13:37:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211201213402.22802-1-sergio.paracuellos@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/1/21 1:34 PM, Sergio Paracuellos wrote:
> Driver is not ready yet to be compiled as a module since it depends on some
> MIPS not exported symbols. We have the following current problems:
> 
> Building mips:allmodconfig ... failed
> --------------
> Error log:
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
> ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> 
> Temporarily move from 'tristate' to 'bool' after a better solution is ready.

s/after/until/

> 
> Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
> simplify condition.
> 
> Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Reviewed-and-Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/pci/controller/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 93b141110537..7fc5135ffbbf 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -332,8 +332,8 @@ config PCIE_APPLE
>   	  If unsure, say Y if you have an Apple Silicon system.
>   
>   config PCIE_MT7621
> -	tristate "MediaTek MT7621 PCIe Controller"
> -	depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
> +	bool "MediaTek MT7621 PCIe Controller"
> +	depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
>   	select PHY_MT7621_PCI
>   	default SOC_MT7621
>   	help
>