Message-ID: <c55e7903-aeb5-c117-6e56-c93e0728e46e@intel.com>
Date:   Wed, 1 Dec 2021 16:39:32 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] selftests/resctrl: Return KSFT_SKIP(4) if resctrl
 filessystem is not supported or resctrl is not run as root
Content-Language: en-US
To:     "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
References: <20211110093315.3219191-1-tan.shaopeng@jp.fujitsu.com>
 <20211110093315.3219191-3-tan.shaopeng@jp.fujitsu.com>
 <6b9ed425-cadb-15df-4c4f-eb1dc0b814dd@intel.com>
 <TYAPR01MB63303777416D1D3C0EF066278B689@TYAPR01MB6330.jpnprd01.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <TYAPR01MB63303777416D1D3C0EF066278B689@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjN5T2Vuc0o3a3lkZWdGdlIzTWlUdkRpQjVtWmpuaXVMUHVXZ3pQTHBZMUJP?=
 =?utf-8?B?b3NUcGsrejMrTzVWdWl1WTJRd3BodzZ4d2tzeDhrT3dEVWJMbEV0UVF3WnFW?=
 =?utf-8?B?eHp5RlBHaFRMa2RvU090NTVwS1ZMV0RQOGZ1ZUhrS2xrbnRGRW5QNUhWTEJY?=
 =?utf-8?B?Zk95UzVaaldYVkZZTDNlMUdYdmV4NUJQdG1teDhWaWgzWVdxVXQraDh1R3pP?=
 =?utf-8?B?N3lwOG9JRS9WTUtqWThvWCtKWmJGY0Q0MUlZUTZubzJ4Tld1a2pHNEx5V3lV?=
 =?utf-8?B?RmNIOThyTHBUVGVoSnhTbnp1Ym1TQXVjL3hOalpjOWlaZDZoamlkV01CS2xn?=
 =?utf-8?B?TCtXUDRMRGYwSkdBUkFTaFB1b3JkMGdUZ3FudlFxQ1pMZGh3d2dtNU1pL3ho?=
 =?utf-8?B?TVgveGRQUWtCS3Q4TzRIL0loN0Z1WEtCKzVJMDJHT2o1L25lRjVpUXg4TDht?=
 =?utf-8?B?a2RuWTYwamtQVzJuRUJmVzN2Mlh3ZkpsdG9EQnFEL1FyeWo1Z002QWh4dzY3?=
 =?utf-8?B?TTBWOW13eTBPcmJ2OXhNWWZDbXM3VGVyVmtrZGg0OEdzSFJaalhpY1RHQ1dP?=
 =?utf-8?B?U0c5dDEva2VXd2t6bHdCczViTkFnMjMxdEVCcEwxbjhNcXZVb3FURGRSVnlw?=
 =?utf-8?B?K1kzZElOT21uNE45QnJIdFFKRTJ4UUo1SE1JSWI0YmFVZWVtMlVOZlBBVnZ0?=
 =?utf-8?B?NzhpbTVSbDFXUEVKcjJNMklUK3pZK201T1RwWHg1OG0zQStocGM3aDhBL08y?=
 =?utf-8?B?U1QvOEVBQkkxYWFiNkxZSWJyMDlraytteFcvaFBDRTFTRFNqTzNXOWRFblJu?=
 =?utf-8?B?aXc0bGhteWwrTDl4WlEvK1VwaDB6UlRvblhoT0FqdDNZa3ZKT1l4MCtSZFZL?=
 =?utf-8?B?ZWVrSEQyc3BHeG1uOW45aExIeU1WV1djVkFIczd0WkRwQWsyODhxSGQzQy9M?=
 =?utf-8?B?Q3hlUkFJTk5idElGSXFTYTJCUEdqQXZ2OWdwK01PVG1YVHQ2bmRwR2tyYjht?=
 =?utf-8?B?SDE5Q2h6UW9iYmNUQ3E2a1ZXTzRscmhuOVhRSFNsVGQ3N1ltd1pvQUdJdXFR?=
 =?utf-8?B?SmJ6a3l0K2tMOXpkdGdSL1ZqK0t3N3pEczQwVVRuSjdRYStWZTdrWlo5TGk5?=
 =?utf-8?B?QnVFZ0hKQ3ptVnBEcU5iVGFLSUNaTUZNY2cvVW4wUFB5UVRiSGcySFo3bnVq?=
 =?utf-8?B?N3g0ZERxbTVjdTY3ZWhXV1E1ZmladVBzb0hQaHEveFFUU1YzZWxrcUo5blMr?=
 =?utf-8?B?ZjRNNVJVVWtkR2dMT0k1Nk11a00rN0NDVGorK2xXYXdaNDVhS01EWVlzNUdW?=
 =?utf-8?B?dnRYRnp6djJXZmJ3ak1pbVhueWxxU2kxY0RLWkJabEQzdWVvYmxJSjlpcE9F?=
 =?utf-8?B?TEczMzAwa3R4NVVJdjNIemUwZXovMExsZkFuRWo4MDRNZHVDQlFnb3JFeXRn?=
 =?utf-8?B?aGNZb05RZmFkaEFGVWY4R0xORjBUY2dQS0hzdHBCSFBYL3BNU2lIRHlLZjhV?=
 =?utf-8?B?N3gwTmFweVN0VmhwVUplWVFXZVJ2K1FGY1pNNHhXU2JzTXJvY3E1VTIvY3dk?=
 =?utf-8?B?MFRucVdVZitFNHlCeWxtbWxJTmt0WUVaSlhQYTZBbGZTajdyTHVkS2tCcTQ3?=
 =?utf-8?B?ZjNlQ2lFOGwvbGs0S1JQQWRSczV0clUyRHVoYy8xemVrREFkSi9TSWNXNmR6?=
 =?utf-8?B?cW5GeVMrdU9aMEloUURzY08rdVRoZ2l2a3dDdEFFV3N3eGJHREpPZ1BiZ005?=
 =?utf-8?B?c0p0R3kxQmQwTmo0bzIwN0JNVjF5dGd5UE5YMlF4a2JQaitDRDkvT2dBNVRO?=
 =?utf-8?B?NzNjMTB2N3JqTDNQd01hMTllTS9UQU4ySEdnazQwQ1d3aHhPWjR4T2dRZi9z?=
 =?utf-8?B?UnJsT3VWUXU2ODgrQ0dnbk05dHRaa3VOMVZvZm1yVWp6b2hBTjNoYUpJVENu?=
 =?utf-8?B?SCtGZ25iVHoycWpjVEdNbXo2VFJZT1hzMEZxT2lTd3h6OHFkbEJ4SVRLK2pG?=
 =?utf-8?B?MFBYcHdFOUVJRExDSXJGZ0lydjFtVUtwZkY3ZkhjaUZtUGgvN01RRXRxUXpP?=
 =?utf-8?B?b3FNSCtad2IvZkR4WHZ4d20rQkYvRS9rUG1EWjMvd09pVXhMMG94cHZYUVZW?=
 =?utf-8?B?cWI1dVRveEgxbWh4VjZ5eWJiMW5LemZUSHUyc0JPMlVvYUxWZWpqYUJNWVRB?=
 =?utf-8?B?OU9adzZCa2JNMDR2MDZBa3FNRjBsMUMyL09takhtQ3MrZTBZMHlhYzVUdGdE?=
 =?utf-8?Q?h8S/Cy0+l+gvNOqbmoztwiRGR4vwpPm94LkDUyxCBQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 990f4b97-c4a4-45b7-6e58-08d9b52c37dd
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 00:39:38.8163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IKFsGZN+nlm3FeXuANHQGFb9ldzJ4/qjyw2I43CtPQT9QyO/nwagjyP2xFENPO5RaRVh7lwUjN7WGOCRK7m0TgLXDXqGekUsyyEjJE5UW6o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3970
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 11/30/2021 6:36 PM, tan.shaopeng@fujitsu.com wrote:
> Hi Reinette
>   
>> (subject line and commit message: filessystem -> file system)
> Thanks.
>   
>> On 11/10/2021 1:33 AM, Shaopeng Tan wrote:
>>> From: "Tan, Shaopeng" <tan.shaopeng@jp.fujitsu.com>
>>>
>>> To unify the return code of resctrl_tests with the return code of
>>> selftest set, return KSFT_SKIP (4) if resctrl filessystem is not
>>> supported or resctrl is not run as root.
>>
>> Could you please elaborate how changing ksft_exit_fail_msg() to
>> ksft_exit_skip() accomplishes the goal of unifying the return code?
>> What is wrong with using ksft_exit_fail_msg()?
> 
> In selftest framwork,
> if a test need root privileges, but it is run as user privileges,
> the test result will counted as a SKIP item, instead of a FAIL item.

Thank you for the details. I think it is important to highlight that a 
skipped test is marked as successful to not unnecessarily report a 
feature failure when there actually is a failure in the test environment.

Reinette