Date:   Thu, 2 Dec 2021 09:12:18 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Miguel Ojeda <ojeda@kernel.org>
Cc:     Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] compiler_types: mark __compiletime_assert failure as
 __noreturn
Message-ID: <20211202061218.GA30793@kili>
References: <20211014132331.GA4811@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211014132331.GA4811@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E58o2XRdexdXnTqfEv8xVdO/0e4RyxJ4u0JFzO42qBgttEaPym+E6bCKOR73?=
 =?us-ascii?Q?dAZv7k49FprztqS148dl6NJfEoPKMqfbpysl8E6GgSevDdPTbWLEh+etcJc2?=
 =?us-ascii?Q?dxKQOR5qHX4XO7ORX5lscdioPo79IqdxrvfN7EvYf375dO95ATzTOWvahJmT?=
 =?us-ascii?Q?I3zrjAmRj4Yl+XNRYhpWzrr/fTr8F15sydvZUcYY4SLmcVmzm7nRIJ6rzLRJ?=
 =?us-ascii?Q?UGairXxgLm+CFnzbfVJzkx07hXJb7m7D2iQftFok7MhLk5swlC9h7Wb9js8q?=
 =?us-ascii?Q?/UZ9RS80S4tGzq7+sRwqAr6Fih6mN3gxT2h2eWieMx76m5riOrH/IjfjZ9wo?=
 =?us-ascii?Q?bIHMJ7y11BTfhpnqUt6g5dBGvh0j2+3xmEbh2B3fbllAJw+lSrvEFG3Jucdr?=
 =?us-ascii?Q?eTEmoJCdqnfjKsPLsoSKQJ+sEBjqhOKnHaxT89+lPV+aHJ/UCsqRFsXvMhkt?=
 =?us-ascii?Q?MziRP6pnTmcpx91e3Zpe4daA12+6zDWo1uiFfQehsBPuWxSBMJ0VB17pB9ae?=
 =?us-ascii?Q?pU42s580zbkNSdLxFH7eYCFbIErK7s3wmkA6bF3WsbKemiTBGpPabJWQSvu4?=
 =?us-ascii?Q?Hfpfursw6Ts+nTX8HJj6kgaQkikzf7BDrn4dMuBcZHRCG4yfAglA0q+qVg5e?=
 =?us-ascii?Q?Absf59VofSVSTb58F3zoEcKK+p3UDLr6SrDpXUNV/dKMv53y42NYifK5hZv2?=
 =?us-ascii?Q?uxgL+ihEahADPEbv4H71J2mflk5zIaYk4cesuvwN9u0o+B3V1qerhuxmodfF?=
 =?us-ascii?Q?alBDQOcsYUyuh8g8noBHqAP3N0Tj3FJd99304y41NFS+lJrasX/B0N9rLN1y?=
 =?us-ascii?Q?wRD38y4ceJAcE3JRW29x7ekH66GaNk3a8P2G2qzQ9zAMqAfcvhnelZ/cCfKY?=
 =?us-ascii?Q?MenJQB0iOjIEl6EC2bgIUTcDbe3IIH7cVs2WvmDbxv5RbMbsas+9tBExTaXc?=
 =?us-ascii?Q?B56+7X3G3imRlDmXMm1FB0NIxs604Fd2OXIlIHHcC5omrFK3ob7MnG8mYnO3?=
 =?us-ascii?Q?EsyPk9eUDoxgAawlgyo4il7KmWodvPdKPvO6eAXIjXNwfrejont4y+8OAWSp?=
 =?us-ascii?Q?HVGObJTEbReBfWZztTAyV3z4UG6k3EHCra0WUpQriOTINu/1UCzjDRVoo/Gt?=
 =?us-ascii?Q?QwJ1lN2omWEl8QH10Yoh+lZkgHcq0ttib0/WovMu/27mGKEeWas2qPQtjAjP?=
 =?us-ascii?Q?3AG5PgrL+iCWpIlh7+NYitQAr438vl2o6YZBPwANqscHkWnx6RSTJJ/+eSsY?=
 =?us-ascii?Q?lgXyqE6ky8Zk9+AMf8yucDqsdvIzzGUYvamcB4gE/RB0gDeFmCECNwafnYCn?=
 =?us-ascii?Q?BY16O4bfyHskl+KezBE9EnLv7Vy4DSZ+/uEktsTu1HMWm5KIXycPQBgb/NpV?=
 =?us-ascii?Q?BzPPZxRAkrWBbRDdID4rDTM1e+IO5yT3w2+fWvqd7sbmmoME+SIByK8yJone?=
 =?us-ascii?Q?DEcd21DK8IJl9oK+K+9/rRx/Qaht1evVeVCCSABuZSLj0/pv6DcWzcgev3LX?=
 =?us-ascii?Q?ie48bb/6BwxhJOnPFLpuIdSrmUomg9aQnH3PQTTVPCCzLiRXb3xbiqFAK8hQ?=
 =?us-ascii?Q?5uYT9I0CyaZo3o9XjfXlvr8C+Fp/N9/XZ+m7IXqOhm0TjJAn2cM/kG/IZvP/?=
 =?us-ascii?Q?cTZAe4om781uqNSSAKJwWUsb3Nclc28NHIaQCCm7nYhRX+D15aX6McKbq9TD?=
 =?us-ascii?Q?VAF0KrHaAu4f7s9fQG7QVbtfmvU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d429a96-3bb9-4b0e-91bc-08d9b55ab8af
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 06:12:30.2042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m0WsNnizNdsI81MUZydOfy8+L9Lmiv+cpfU+X+m3W1Jk8WzAxm190fSxoF8Xx+ijITjBaW838bzuropS8/K8zHYVPS7vmIBsl2X8vF+CA9Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2127
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10185 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112020034
X-Proofpoint-ORIG-GUID: ca9qol357TRk4QZ0wt19SUo6RdlOS8V4
X-Proofpoint-GUID: ca9qol357TRk4QZ0wt19SUo6RdlOS8V4
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 14, 2021 at 03:23:31PM +0200, Miguel Ojeda wrote:
> `__compiletime_assert` declares a fake `extern` function
> which appears (to the compiler) to be called when the test fails.
> 
> Therefore, compilers may emit possibly-uninitialized warnings
> in some cases, even if it will be an error anyway (for compilers
> supporting the `error` attribute, e.g. GCC and Clang >= 14)
> or a link failure (for those that do not, e.g. Clang < 14).
> 
> Annotating the fake function as `__noreturn` gives them
> the information they need to avoid the warning,
> e.g. see https://godbolt.org/z/x1v69jjYY.
> 
> Link: https://lore.kernel.org/llvm/202110100514.3h9CI4s0-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

This patch is kind of a headache for Smatch.

The patch basically turns BUILD_BUG() into BUG().  That's fine.

But it also turn BUILD_BUG_ON(!__builtin_constant_p(foo) into a BUG_ON().
A lot of places call BUILD_BUG_ON() to ensure that functions are inlined
and the build breaks if not.  For example, the FIELD_GET() macro will
trigger a build bug if "mask" is not a compile time constant.

   295  static __always_inline u32 cal_read_field(struct cal_dev *cal, u32 offset, u32 mask)
   296  {
   297          return FIELD_GET(mask, cal_read(cal, offset));
   298  }

Unfortunately, Smatch doesn't respect the __always_inline annotation so
now it thinks cal_read_field calls BUG() and records it as a noreturn
function.  And all the callers get marked as noreturn functions as well.

Could we make it so that BUILD_BUG() is a noreturn function and
BUILD_BUG_ON() is left as it was?

regards,
dan carpenter