MIME-Version: 1.0
References: <104dcbfd22f95fc77de9fe15e8abd83869603ea5.1637927673.git.geert@linux-m68k.org>
 <YagEai+VPAnjAq4X@robh.at.kernel.org>
In-Reply-To: <YagEai+VPAnjAq4X@robh.at.kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 2 Dec 2021 11:10:01 +0100
Message-ID: <CAMuHMdW5Ng9225a6XK0VKd0kj=m8a1xr_oKeazQYxdpvn4Db=g@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema
To:     Rob Herring <robh@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        netdev <netdev@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michal Simek <michal.simek@xilinx.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob,

CC Michal

On Thu, Dec 2, 2021 at 12:25 AM Rob Herring <robh@kernel.org> wrote:
> On Fri, Nov 26, 2021 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
> > Convert the Cadence MACB/GEM Ethernet controller Device Tree binding
> > documentation to json-schema.
> >
> > Re-add "cdns,gem" (removed in commit a217d8711da5c87f ("dt-bindings:
> > Remove PicoXcell bindings")) as there are active users on non-PicoXcell
> > platforms.
> > Add missing "ether_clk" clock.
> > Add missing properties.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml

> > +  '#stream-id-cells':
> > +    const: 1
>
> I can't figure out why you have this here. I'll drop it while applying.

See arch/arm64/boot/dts/xilinx/zynqmp.dtsi and
drivers/iommu/arm/arm-smmu/arm-smmu.c.

It wasn't clear to me if this is still needed, or legacy. Michal?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds