Message-ID: <22db4807-7772-abe6-50c6-5812d9692ccc@ti.com>
Date:   Thu, 2 Dec 2021 16:14:23 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: add timesync router node
Content-Language: en-US
To:     Christian Gmeiner <christian.gmeiner@gmail.com>,
        <linux-kernel@vger.kernel.org>
CC:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>
References: <20211109150158.164778-1-christian.gmeiner@gmail.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20211109150158.164778-1-christian.gmeiner@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 11/9/21 8:31 PM, Christian Gmeiner wrote:
> The Time Sync Event Router (TIMESYNC_INTRTR0) implements a set of
> multiplexers to provide selection of active CPTS time sync events for
> routing to CPTS capable modules.
> 
> This patch adds DT node TIMESYNC_INTRTR0 using "pinctrl-single" bindings.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index 42d1d219a3fd..c9321a80353a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -564,6 +564,14 @@ cpts@39000000 {
>  		ti,cpts-ext-ts-inputs = <8>;
>  	};
>  
> +	timesync_router: timesync-router@a40000 {

Node with "pinctrl-single" would need to be named pinctrl@reg.
Else this would probably fail dtbs_check once pinctrl-single bindings is
converted to YAML format.

> +		compatible = "pinctrl-single";
> +		reg = <0x0 0xa40000 0x0 0x800>;
> +		#pinctrl-cells = <1>;
> +		pinctrl-single,register-width = <32>;
> +		pinctrl-single,function-mask = <0x000107ff>;
> +	};
> +
>  	usbss0: cdns-usb@f900000{
>  		compatible = "ti,am64-usb";
>  		reg = <0x00 0xf900000 0x00 0x100>;
> 

Regards
Vignesh