Subject: Re: [PATCH] media: ipu3: don't use recursion at the Kernel
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     linuxarm@huawei.com, mauro.chehab@huawei.com,
        Bingbu Cao <bingbu.cao@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Yong Zhi <yong.zhi@intel.com>, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org
References: <cf020b6a04b3a9d7f08750927b1d100f63ff4689.1638445455.git.mchehab+huawei@kernel.org>
From:   Daniel Scally <djrscally@gmail.com>
Message-ID: <1a1437f7-89e9-73f5-a197-c2b7c9536846@gmail.com>
Date:   Thu, 2 Dec 2021 12:31:47 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <cf020b6a04b3a9d7f08750927b1d100f63ff4689.1638445455.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi Mauro

On 02/12/2021 11:44, Mauro Carvalho Chehab wrote:
> The Kernel stack is too small. Doing recursions there is a very
> bad idea, as, if something gets wrong, it could lead to data
> corruption.


TIL - I'll bear that in mind in the future, thanks.

> So, re-implement cio2_check_fwnode_graph() to avoid
> recursion.
>
> Compile-tested only.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>


FWIW:

Reviewed-by: Daniel Scally <djrscally@gmail.com>

Tested-by: Daniel Scally <djrscally@gmail.com>

> ---
>  drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
> index 356ea966cf8d..8e4f250a8b56 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
> @@ -1691,16 +1691,15 @@ static int cio2_check_fwnode_graph(struct fwnode_handle *fwnode)
>  {
>  	struct fwnode_handle *endpoint;
>  
> -	if (IS_ERR_OR_NULL(fwnode))
> -		return -EINVAL;
> -
> -	endpoint = fwnode_graph_get_next_endpoint(fwnode, NULL);
> -	if (endpoint) {
> -		fwnode_handle_put(endpoint);
> -		return 0;
> +	while (!IS_ERR_OR_NULL(fwnode)) {
> +		endpoint = fwnode_graph_get_next_endpoint(fwnode, NULL);
> +		if (endpoint) {
> +			fwnode_handle_put(endpoint);
> +			return 0;
> +		}
> +		fwnode = fwnode->secondary;
>  	}
> -
> -	return cio2_check_fwnode_graph(fwnode->secondary);
> +	return -EINVAL;
>  }
>  
>  /**************** PCI interface ****************/