Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <b11f646dda189f490c06bf671f64a2cc0af4d45c.1638397089.git.christophe.jaillet@wanadoo.fr>
References: <b11f646dda189f490c06bf671f64a2cc0af4d45c.1638397089.git.christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] media: mc: mc-entity.c: Use bitmap_zalloc() when applicable
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
        sakari.ailus@linux.intel.com
Date:   Thu, 02 Dec 2021 12:38:05 +0000
Message-ID: <163844868581.3059017.16653620248778368715@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Christophe JAILLET (2021-12-01 22:19:40)
> 'ent_enum->bmap' is a bitmap. So use 'bitmap_zalloc()' to simplify
> code, improve the semantic and avoid some open-coded arithmetic in
> allocator arguments.
>=20
> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> consistency.
>=20
> While at it, remove a useless 'bitmap_zero()'.

Ah, yes kcalloc zeros memory, so it is doing a redundant clear as well.
Changing to bitmap_zalloc looks a lot better though.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/media/mc/mc-entity.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index c02340698ad6..b411f9796191 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -48,12 +48,10 @@ __must_check int __media_entity_enum_init(struct medi=
a_entity_enum *ent_enum,
>                                           int idx_max)
>  {
>         idx_max =3D ALIGN(idx_max, BITS_PER_LONG);
> -       ent_enum->bmap =3D kcalloc(idx_max / BITS_PER_LONG, sizeof(long),
> -                                GFP_KERNEL);
> +       ent_enum->bmap =3D bitmap_zalloc(idx_max, GFP_KERNEL);
>         if (!ent_enum->bmap)
>                 return -ENOMEM;
> =20
> -       bitmap_zero(ent_enum->bmap, idx_max);
>         ent_enum->idx_max =3D idx_max;
> =20
>         return 0;
> @@ -62,7 +60,7 @@ EXPORT_SYMBOL_GPL(__media_entity_enum_init);
> =20
>  void media_entity_enum_cleanup(struct media_entity_enum *ent_enum)
>  {
> -       kfree(ent_enum->bmap);
> +       bitmap_free(ent_enum->bmap);
>  }
>  EXPORT_SYMBOL_GPL(media_entity_enum_cleanup);
> =20
> --=20
> 2.30.2
>