Date:   Thu, 2 Dec 2021 15:31:49 +0100
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     Borislav Petkov <bp@alien8.de>
Cc:     X86 ML <x86@kernel.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] notifier: Return an error when a callback has already
 been registered
Message-ID: <20211202143149.jeqf4bhhsr534pwo@linutronix.de>
References: <20211202133601.23527-1-bp@alien8.de>
 <20211202141630.rdkrtrltxhzdqtyb@linutronix.de>
 <YajW6LRVJi2IEHlU@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <YajW6LRVJi2IEHlU@zn.tnic>
Precedence: bulk

On 2021-12-02 15:23:36 [+0100], Borislav Petkov wrote:
> On Thu, Dec 02, 2021 at 03:16:30PM +0100, Sebastian Andrzej Siewior wrote:
> > >  	while ((*nl) !=3D NULL) {
> > > -		if (unlikely((*nl) =3D=3D n)) {
> > > -			WARN(1, "double register detected");
> > > -			return 0;
> >=20
> > This could be s/0/-EEXIST/ or do I miss something?
>=20
> It is...
=E2=80=A6
> > > -		}
> > > +		if (unlikely((*nl) =3D=3D n))
> > > +			return -EEXIST;
> 			^^^^^^^^^^^^^^^
>=20
> ... right here.

I meant without the extra function. I'm fine either way, just curious :)

Sebastian