Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EECC433EF for ; Thu, 2 Dec 2021 15:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347607AbhLBPmj (ORCPT ); Thu, 2 Dec 2021 10:42:39 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:43272 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347358AbhLBPmg (ORCPT ); Thu, 2 Dec 2021 10:42:36 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1D0B81FD39; Thu, 2 Dec 2021 15:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638459553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PqriVwlxl0/gBzqmRZ+q2vvUO8ThOH0XH1qb2rFeHyY=; b=KQOrHpuewT7MmWAb4k3jGc3hakWJJHkPv/nIfWiFtQragtMA6PrNR/p+Vb9VmPWRVlXYYp NuORAX6YmcV/Jp9za1vcMS7PNeI5a3CtB3dxbYhwM6qUwA4Ucj9jM2KvN9G0v17ro40V7z IbAkG1fyoMG5MMZN5pq/CrrM2JfvRe0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638459553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PqriVwlxl0/gBzqmRZ+q2vvUO8ThOH0XH1qb2rFeHyY=; b=JO0TNKZ2zbO9lFdx+QIsP62Xp11bIsxUApgZmRLKdRDoYfGtpFrVccuF5dmGAl5JZHKXUF aXtkbeEm6sr+bsAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 102B5A3B89; Thu, 2 Dec 2021 15:39:13 +0000 (UTC) Date: Thu, 02 Dec 2021 16:39:13 +0100 Message-ID: From: Takashi Iwai To: Werner Sembach Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Fix quirk for TongFang PHxTxX1 In-Reply-To: References: <20211202152843.818617-1-wse@tuxedocomputers.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Dec 2021 16:35:23 +0100, Werner Sembach wrote: > > Am 02.12.21 um 16:28 schrieb Werner Sembach: > > This fixes the SND_PCI_QUIRK(...) of the TongFang PHxTxX1 barebone. This > > fixes the issue of sound not working after s3 suspend. > > > > When waking up from s3 suspend the Coef 0x10 is set to 0x0220 instead of > > 0x0020. Setting the value manually makes the sound work again. This patch > > does this automatically. > An educational question: Is there any, at least partial, documentation available on what these Coef values actually do > besides https://www.kernel.org/doc/html/v5.15/sound/hd-audio/realtek-pc-beep.html ? Unfortunately, no. It's a completely vendor-specific black magic. Takashi