Date:   Thu, 2 Dec 2021 16:01:59 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Alexander Monakov <amonakov@ispras.ru>
Cc:     linux-edac@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: Excessive delays from GHES polling on dual-socket AMD EPYC
Message-ID: <Yajt9zml8Iyd/VVn@yaz-ubuntu>
References: <878e4019-3a88-798e-4427-7efb5289a4e1@ispras.ru>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878e4019-3a88-798e-4427-7efb5289a4e1@ispras.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XlBzTq5e19AaXEQAeT+edQDtTALQ7q0wGryc/IDIarKRyH7jFj7iwp1qedSw?=
 =?us-ascii?Q?+3rgvD06u+Vg1shsFzeMAvHTrdqgPRoTYoUa1540ieIJpBDstHJP4WOGtlK1?=
 =?us-ascii?Q?F9Ro3+YyqwTjN3nrk6UGDxC8RdtTcVk6VHJrqp/DxBnAF4U0qMUEKcDZhVd7?=
 =?us-ascii?Q?kMGg2Py6JiMx0uFC91XA6gV7Zsr7aWp0kbP/7wA/IRW0mtPwAyTHUA6bKfTQ?=
 =?us-ascii?Q?lWMk7L8IaFIvyZsgjfkVT1Mq8xEBysGHuE1npJwHNwpyQlZQNPdd89gdCi1I?=
 =?us-ascii?Q?+qacZkuAjIs1sOLO29dYvw94jbSGY7GfLEzb/eJEpiLFc7flpa9Q+BXEWHja?=
 =?us-ascii?Q?uA6OaUjCr4fHoq1Cf+ireVf3pAU1MsxtkOi4gkT1T8n6tqChAjNCIiXtQKXZ?=
 =?us-ascii?Q?p9/q+y86xgQAiwVvdS9n+rU5O9pV5aad/gzWZAQmeG5pkuhqNsGhTADPmg+C?=
 =?us-ascii?Q?ZCCBmchmlQFf/KkdsvhUZMXTCxGIlFQg+hEM1eCRFyMpEvdVyhHd/PDva6l1?=
 =?us-ascii?Q?n4qkxKHpElhUTcXDh2nXx5PFOsTMi8A8BMkhwBQiclz5XyFxXUuRMU4G9Mch?=
 =?us-ascii?Q?xWFZdW8Jb/V0TMaaHg+PAHIY1AadCQ44/VooaH6qzxRT5dX1n8BRpeI392pi?=
 =?us-ascii?Q?y0GXyVy9nNZ12Bk+NSQ73S0MzKFE8fFWQIDWsZ3dUrm9kQC9GfgQgXm0ml8S?=
 =?us-ascii?Q?45ha+B+p66UDivdmQ1jCSOB4Z7in5XcN4UCWrPxrrd3iR8MCaz6f+k+EMm7C?=
 =?us-ascii?Q?NV7lY2+KWaxtfzqZSAyMLa59mzp3KR1z7Liyo8VH6vOeurEeQU94AI3OXqNa?=
 =?us-ascii?Q?DhcljRHjYkYitWxC/JmHFlTmupgS6Zvz9R/nBL4o7tRw7aqYGdKvQF/MsySv?=
 =?us-ascii?Q?z/L7aNwcgAlvdPMbYCkufE6SftW62mkywhDe3uupJLzIAY1xPYo5zKGLb0Rr?=
 =?us-ascii?Q?d+TrbOda++04gvGT9s+0Rd744yMHJjnNFq5tgSnAVFszm89AHcfOqFWa25+u?=
 =?us-ascii?Q?G8fUcaErgjOGFuEVOi4PZdp6H0mBdyWzJXkQVcNEj/YYzB9T3sBLFH4cnlGp?=
 =?us-ascii?Q?s9NAi5uMxCrV6byCQ9uWdNdxx2xYcgHvdUISwQ9i82VJdIxvBDTVWxpZmwmD?=
 =?us-ascii?Q?BfZPerHQbPSo+t4MfZ1X0mQvKRcAyY/cINoPsKoyMuHqa9k+IAPDbeKppTv+?=
 =?us-ascii?Q?a3rK25ic9Vnt3vzskR43abYiGbm2BXy/KWlg1WdtHTcGuQRkw2XHfLYdJ2b8?=
 =?us-ascii?Q?AtOVo6K3dx07RLArxD1dqJqrrUvt0xCU2pXoKn+eAu2Zf3XDsEXdCH+GEsqg?=
 =?us-ascii?Q?h1spcx/8JgSHu+41lHi2srJgiNWY1Mb2mRTYYKRDMG6PZ9MwH2MnYnHz8mb3?=
 =?us-ascii?Q?hKYEOq3vnAdE1C4L9PUCdItabWsqV+T6FbrvuW1L4dcc/w4ynrlWl9xBKGAS?=
 =?us-ascii?Q?3RDlm8Gw3QE18ji76HDVm3dV4rSrHn5uQyZ0csp6fOgp0nG4Mc94gIFho35E?=
 =?us-ascii?Q?qQzcd+ce56ZMFAfXQi4mfIwjKR0yFQXTW7AkMX6qImWKI8Y83ZXMptGMGA56?=
 =?us-ascii?Q?ynck5OJbOfmzWJn7a0RNdvuSnnRUAT0hXsni3VMoYkaMwGU6VPLEGFfOhrWc?=
 =?us-ascii?Q?JIlI3KwyAqW4ea29w7Nq2Ew=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64518a33-275e-43a1-5d9f-08d9b5ad1a16
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 16:02:12.2688
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zgQW9vFthHj2ZCS0UNexO5Te57mpzTbXEwQgJp4znsCldyMxjeiAu785tF1gsYc2HkCVDOVXpG1fkQ+jL6yubA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2978
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 28, 2021 at 12:40:48AM +0300, Alexander Monakov wrote:
> Hello world,
> 
> when lightly testing a dual-socket server with 64-core AMD processors I
> noticed that workloads running on cpu #0 can exhibit significantly worse
> latencies compared to cpu #1 ... cpu #255. Checking SSD response time,
> on cpu #0 I got:
> 
> taskset -c 0 ioping -R /dev/sdf
> 
> --- /dev/sdf (block device 1.75 TiB) ioping statistics ---
> 70.7 k requests completed in 2.97 s, 276.3 MiB read, 23.8 k iops, 93.1 MiB/s
> generated 70.7 k requests in 3.00 s, 276.4 MiB, 23.6 k iops, 92.1 MiB/s
> min/avg/max/mdev = 33.1 us / 41.9 us / 87.9 ms / 452.6 us
> 
> Notice 87.9 millisecond maximum response time, and compare with its
> hyperthread sibing:
> 
> taskset -c 128 ioping -R /dev/sdf
> 
> --- /dev/sdf (block device 1.75 TiB) ioping statistics ---
> 80.5 k requests completed in 2.96 s, 314.5 MiB read, 27.2 k iops, 106.2 MiB/s
> generated 80.5 k requests in 3.00 s, 314.5 MiB, 26.8 k iops, 104.8 MiB/s
> min/avg/max/mdev = 33.2 us / 36.8 us / 89.2 us / 2.00 us
> 
> Of course maximum times themselves vary from run to run, but the general
> picture stays: on cpu #0 I get about three orders of magnitude
> longer latencies. I think this is outside of "latency-sensitive
> workloads might care" territory and closer to "hurts everyone" kind of
> issue, hence I'm reporting it.
> 
> 
> On this machine there's AMD HEST ACPI table that registers 14342 polled
> "generic hardware error sources" (GHES) with poll interval 5 seconds.
> (this seems misdesigned: it will cause cross-socket polling unless the
> OS takes special care to divine which GHES to poll from where)
> 
> Linux setups a timer for each of those individually, so when the machine
> is idle there's approximately 2800 timers per second invoked on cpu #0.
> Plus, there's a secondary issue with timer migration:
> get_nohz_timer_target will attempt to select a non-idle CPU out of 256
> (visiting some CPUs repeatedly if they appear in nested domains), and
> fail. If I help it along by running 'taskset -c 1 yes > /dev/null' or
> disable kernel.timer_migration entirely, it drops maximum latency in the
> above ioping test to 1..10ms range (down to two orders of magnitude from
> three).
> 
> I guess the short answer is that if I don't like it I can boot that
> server with 'ghes_disable=1', but is a proper solution possible? Like
> requiring explicit opt-in to honor polled GHES entries?
>

Hi Alexander,

I believe the large number of GHES structures you have are intended to be used
for the ACPI "GHES_ASSIST" feature. The GHES structures in this case are not
to be used as independent sources. However, this feature is not implemented
yet in Linux, so the kernel does set up these GHES structures as independent
error sources.

One way to avoid the issue is for the firmware to give a large polling
interval in the GHES structures. The kernel will still set up timers for each
structure, but there should be less interference from them. The ACPI spec
seems to allow a polling interval up to 0xFFFFFFFF ms.

Ultimately, I think we'd want the kernel to ignore the GHES structures used
for GHES_ASSIST, and then GHES_ASSIST support can be implemented and used
where appropriate.

I can send a patchset for ignoring the structures. This would be setup for
another set than can fully implement the GHES_ASSIST feature. Would you be
willing to test out that first set to see if it resolves the issue?

Thanks,
Yazen