From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFSD: Fix inconsistent indenting
Thread-Topic: [PATCH] NFSD: Fix inconsistent indenting
Thread-Index: AQHX51ehHYBuc7lZqUm9kIyOl/x8NqwfZM0A
Date:   Thu, 2 Dec 2021 16:29:14 +0000
Message-ID: <6609E132-FDDA-490B-B1F5-C6823EB85834@oracle.com>
References: <1638434142-44998-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1638434142-44998-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KEYXIPxA2ibVTWVtpR27ri0p84kCaTWupzSK2i2nUCQx9Uxa29ZuBlH/TdTb?=
 =?us-ascii?Q?+qzbtxBctEtH/ikejtT4isO0FuOD85ARrvckSBKBkgcVLB9q28jTu586OjM5?=
 =?us-ascii?Q?zL6PZutexI6nGlGEqaA1wQG6rYnzLQ6PlFp00ZiO6J/hrSD8JPcz4D0xzBOp?=
 =?us-ascii?Q?wgfz5ESD9IruyAxKreDb1AKqpPW7Qd5QdOdZqk6o9qQACCBKoDnJrWmwMZRe?=
 =?us-ascii?Q?trCbIJrh+hUGbpXsS9E6PPjMrXtz2UB4tWvRUIcpbnlNXesegY5+S3alNU4Y?=
 =?us-ascii?Q?gNuWfzf1J5FWsjqzwPw+HwqlELkf28RTM1rT0f+xAf4pGy3M01HulZ8ZtNeS?=
 =?us-ascii?Q?3uVm/h6P1zVYuYrh465qgIqJLm1VzwMlhZGrNJqcF4oks05+BG4/nTm38eMB?=
 =?us-ascii?Q?m0pNG+yk4Fm+o5cG8O7SPXLyyH0blTti5ICMPpR3tYiF7RlzrE3lF2LSwLpi?=
 =?us-ascii?Q?9j8x94lM0+uMzLSVIqWPbIERFs0UCBKSm4tLAcjiXpfyclhV9KrUZV2AZYqz?=
 =?us-ascii?Q?6ViQ6CT3e1G4CPSgMWPQWzYFVjM4biTbs70gp3kyv5nHJSEfSET+vl9d3yzg?=
 =?us-ascii?Q?EhX+VMaU6rTgGAoMYPVq5DFNx8Bjcdy0DGQX0OCZL3pcGdkeaZzx1DyCfrA5?=
 =?us-ascii?Q?sfPg94QqiN4YrMiDpAvJBUV03MZRWiPR2ZXFPWncN/CtvsoZwpgP91KTz4LZ?=
 =?us-ascii?Q?Lo5maqvlhfbOeIQzm4e8HzMaM/YLROXjz6950iVK5TEAErRVvPSW8GxqJ9Zc?=
 =?us-ascii?Q?qhIuExTBnpKnE9zsOP+TrzLbekrW1h4hB+1RBNVsn5PppbsUiD5wWPy9V+3f?=
 =?us-ascii?Q?T6777cgshiDjOQc5FoyR50o0XQ1Ny9azYtJuZt37l5nSJJLrSXJpkKcihhfW?=
 =?us-ascii?Q?aGNC/P9HCHq58e3D8GUVYVteEAWhXWqNHz9EFJDdpsyyaRLxS7NqelYvAG9V?=
 =?us-ascii?Q?f6OMlxy+KYG2oPstpnC13QmqSt9ZEmop/EvxKQTGaReqNPPzwcZ2OHbI+n7E?=
 =?us-ascii?Q?ZaTS3xHqlMxpb9e5LILvraggRJvXCmn+ergwacTWlMXM4aMUzetKdWPL80jg?=
 =?us-ascii?Q?zXC2dk91AnFqY8c02Td4j1oEJXENudiGk4LeBurCnoK52JuTXACwMtXqYdT/?=
 =?us-ascii?Q?12uPz9wPaDT1oXd9TcrN2XlF8qVcNBrElD9J3flYMT6+2RW06DX/nO8Dl0DS?=
 =?us-ascii?Q?XoKRBpZcKNiEuabd98hxFXgGamom/wZ+bbdCGQBfGeZdcHovtIoTDIJuYKhM?=
 =?us-ascii?Q?S61yOxeTKSP3j+JlSsL8VKw2z4YyqGalVkj5Fwq9P7Jl7SvMf/OkCamKIBo/?=
 =?us-ascii?Q?YX7M2Wamo7Kel+URH4/l1kexPeVn0Ax27cue4NQf6UU7M5IzgAECd1BoOWuz?=
 =?us-ascii?Q?ZgsjXpsw2cRoCxFNeVSu1UFsymUAEWMmuREZcs8/3Q3iP6WTics6H0zk0WIB?=
 =?us-ascii?Q?01WEpFhj0dM88x+Sr2R8GWw5+BqgC1OMieYdPvFWWuEoz77OA2U6Vjx15gzb?=
 =?us-ascii?Q?AoMgdf9+dFgC6NY0VW8aJXYumbE8z4ChlB43pCNsZ8zuvonZfHlQpY+zxpsU?=
 =?us-ascii?Q?fPGORFFyOVSnadDhawntX7c6GcB3/VLNHuki02aCGhYaAkd5vymQ8wFZZpuV?=
 =?us-ascii?Q?6xfFFJPbM12HWA45SK26fxY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9F279E983ADA88488AF5242011E2FF4B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd83116-7cdc-4965-c6a7-08d9b5b0e17b
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 16:29:15.0098
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WwNwid0c5xHd16vzVZ0dG2jhlfCPd7HbuH3smTEF63/+wpeWwjwprwgdiIgICedtf14jqJVE0qVFa4gIgC83GQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3270
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10185 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112020106
X-Proofpoint-ORIG-GUID: 0oH2HqytffykMatX-nnuCHB_JFwO-bwP
X-Proofpoint-GUID: 0oH2HqytffykMatX-nnuCHB_JFwO-bwP
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Dec 2, 2021, at 3:35 AM, Jiapeng Chong <jiapeng.chong@linux.alibaba.co=
m> wrote:
>=20
> Eliminate the follow smatch warning:
>=20
> fs/nfsd/nfs4xdr.c:4766 nfsd4_encode_read_plus_hole() warn: inconsistent
> indenting.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/nfsd/nfs4xdr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index c286690..3031126 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4763,8 +4763,8 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compo=
undres *resp,
> 		return nfserr_resource;
>=20
> 	*p++ =3D htonl(NFS4_CONTENT_HOLE);
> -	 p   =3D xdr_encode_hyper(p, read->rd_offset);
> -	 p   =3D xdr_encode_hyper(p, count);
> +	p =3D xdr_encode_hyper(p, read->rd_offset);
> +	p =3D xdr_encode_hyper(p, count);
>=20
> 	*eof =3D (read->rd_offset + count) >=3D f_size;
> 	*maxcount =3D min_t(unsigned long, count, *maxcount);
> --=20
> 1.8.3.1
>=20

Thanks! I've included this patch in my for-next topic branch.

--
Chuck Lever