User-Agent: Cyrus-JMAP/3.5.0-alpha0-4458-g51a91c06b2-fm-20211130.004-g51a91c06
Mime-Version: 1.0
Message-Id: <1954b7b6-abb8-4a73-9d90-6b2342f73bb8@www.fastmail.com>
In-Reply-To: <20211124073419.181799-10-marcan@marcan.st>
References: <20211124073419.181799-1-marcan@marcan.st>
 <20211124073419.181799-10-marcan@marcan.st>
Date:   Thu, 02 Dec 2021 18:59:51 +0100
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Hector Martin" <marcan@marcan.st>,
        linux-arm-kernel@lists.infradead.org
Cc:     "Marc Zyngier" <maz@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
        "Krzysztof Kozlowski" <krzk@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Mark Kettenis" <mark.kettenis@xs4all.nl>,
        "Philipp Zabel" <p.zabel@pengutronix.de>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "Johan Hovold" <johan@kernel.org>, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 09/11] arm64: dts: apple: t8103: Add PMGR nodes
Content-Type: text/plain
Precedence: bulk


On Wed, Nov 24, 2021, at 08:34, Hector Martin wrote:
> This adds the two PMGR nodes and all known power state subnodes. Since
> there are a large number of them, let's put them in a separate file to
> include.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  arch/arm64/boot/dts/apple/t8103-pmgr.dtsi | 1136 +++++++++++++++++++++
>  arch/arm64/boot/dts/apple/t8103.dtsi      |   24 +
>  2 files changed, 1160 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi 
> b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> new file mode 100644
> index 000000000000..1310be74df1d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> @@ -0,0 +1,1136 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> +/*
> + * PMGR Power domains for the Apple T8103 "M1" SoC
> + *
> + * Copyright The Asahi Linux Contributors
> + */
> +
> +

[...]

> +	ps_atc0_usb_aon: power-controller@88 {
> +		compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate";
> +		reg = <0x88 4>;
> +		#power-domain-cells = <0>;
> +		#reset-cells = <0>;
> +		label = "atc0_usb_aon";
> +	};
> +
> +	ps_atc1_usb_aon: power-controller@90 {
> +		compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate";
> +		reg = <0x90 4>;
> +		#power-domain-cells = <0>;
> +		#reset-cells = <0>;
> +		label = "atc1_usb_aon";
> +	};

These two nodes have AON in their name but can be powered off.
Is this intentional and Apple just labels things a bit weird in the ADT
again?


With that confirmed:

Reviewed-by: Sven Peter <sven@svenpeter.dev>


Best,

Sven