MIME-Version: 1.0
References: <20211202223609.1171452-1-f.fainelli@gmail.com>
In-Reply-To: <20211202223609.1171452-1-f.fainelli@gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 2 Dec 2021 16:41:15 -0600
Message-ID: <CAL_JsqLR=TeKFj1DO-UDcFDcuuw9VUzy9tdxmdK797ywX+fN8g@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     devicetree@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@broadcom.com>,
        Jim Quinlan <jim2101024@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Saenz Julienne <nsaenzjulienne@suse.de>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:BROADCOM STB PCIE DRIVER" <linux-pci@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> The compatible property is required, make sure the binding documents it
> as such.

Yes, though if 'compatible' is not present and matching, the schema is
never applied. I'll apply it later, but I wouldn't be too concerned
fixing any others.

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 1fe102743f82..7c24d711b377 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -76,6 +76,7 @@ properties:
>        maxItems: 3
>
>  required:
> +  - compatible
>    - reg
>    - ranges
>    - dma-ranges
> --
> 2.25.1
>